[Transaction Controller Migration] Rename rawTransaction to rawTx#7264
Merged
vinistevam merged 3 commits intorefactor/transaction-controller-migrationfrom Sep 26, 2023
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## refactor/transaction-controller-migration #7264 +/- ##
=============================================================================
+ Coverage 33.02% 33.04% +0.01%
=============================================================================
Files 1004 1004
Lines 26888 26895 +7
Branches 2131 2131
=============================================================================
+ Hits 8881 8888 +7
- Misses 17571 17573 +2
+ Partials 436 434 -2
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Bitrise E2E pipeline ✔️ |
OGPoyraz
approved these changes
Sep 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
matthewwalsh0
approved these changes
Sep 26, 2023
Contributor
|
All regression tests are passed automatically in the local environment, as well as manual tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR aims to adopt the changes in core renaming
rawTransationtorawTx. The change is part of an effort to align the extension and core controller towards unification.No usage in UI was found.
Manual testing steps
This requires a regression in the transaction as it touches the
TransactionController.Screenshots/Recordings
send-token.webm
send-ERC-token.webm
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Related issues
Fixes https://github.com/MetaMask/mobile-planning/issues/1242
Pre-merge author checklist
Pre-merge reviewer checklist