Skip to content

[Transaction Controller Migration] Rename rawTransaction to rawTx#7264

Merged
vinistevam merged 3 commits intorefactor/transaction-controller-migrationfrom
refactor/rename-rawTransaction-rawTx
Sep 26, 2023
Merged

[Transaction Controller Migration] Rename rawTransaction to rawTx#7264
vinistevam merged 3 commits intorefactor/transaction-controller-migrationfrom
refactor/rename-rawTransaction-rawTx

Conversation

@vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Sep 19, 2023

Description

This PR aims to adopt the changes in core renaming rawTransation to rawTx. The change is part of an effort to align the extension and core controller towards unification.

  • Generated the patch with the changes to rename the properties
  • Add migration and tests to properly rename

No usage in UI was found.

Manual testing steps

This requires a regression in the transaction as it touches the TransactionController.

Screenshots/Recordings

send-token.webm
send-ERC-token.webm

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Related issues

Fixes https://github.com/MetaMask/mobile-planning/issues/1242

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (31744a1) 33.02% compared to head (7475e56) 33.04%.

Additional details and impacted files
@@                              Coverage Diff                              @@
##           refactor/transaction-controller-migration    #7264      +/-   ##
=============================================================================
+ Coverage                                      33.02%   33.04%   +0.01%     
=============================================================================
  Files                                           1004     1004              
  Lines                                          26888    26895       +7     
  Branches                                        2131     2131              
=============================================================================
+ Hits                                            8881     8888       +7     
- Misses                                         17571    17573       +2     
+ Partials                                         436      434       -2     
Files Changed Coverage Δ
app/store/migrations.js 15.42% <100.00%> (+3.52%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinistevam
Copy link
Contributor Author

@vinistevam vinistevam marked this pull request as ready for review September 19, 2023 10:38
@vinistevam vinistevam requested a review from a team as a code owner September 19, 2023 10:38
@vinistevam vinistevam changed the title Refactor: Rename rawTransaction to rawTx [Transaction Controller Migration] Rename rawTransaction to rawTx Sep 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sleepytanya
Copy link
Contributor

All regression tests are passed automatically in the local environment, as well as manual tests.

@sleepytanya sleepytanya added the QA Passed QA testing has been completed and passed label Sep 26, 2023
@vinistevam vinistevam merged commit cf65ed8 into refactor/transaction-controller-migration Sep 26, 2023
@vinistevam vinistevam deleted the refactor/rename-rawTransaction-rawTx branch September 26, 2023 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants