Merged
Conversation
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/rpc-errors@6.4.0 |
Contributor
|
|
cryptotavares
approved these changes
Nov 15, 2024
Contributor
|
Bitrise build https://app.bitrise.io/app/be69d4368ee7e86d/installable-artifacts/3bc9b0ad9309787a Confirming fix: fix.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Rejecting a transaction confirmation caused the app to crash.
This was due to Hermes not supporting the recursive nature of the error
stackduring serialisation.Resolution:
7.0.1of@metamask/rpc-errorssince there are no API breaking changes.Related issues
Fixes: #12240
Manual testing steps
See issue.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist