Skip to content

fix: transaction reject crash#12311

Merged
sethkfman merged 1 commit intomainfrom
fix/transaction-reject-crash
Nov 15, 2024
Merged

fix: transaction reject crash#12311
sethkfman merged 1 commit intomainfrom
fix/transaction-reject-crash

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 15, 2024

Description

Rejecting a transaction confirmation caused the app to crash.

This was due to Hermes not supporting the recursive nature of the error stack during serialisation.

Resolution:

  • Force the use of 7.0.1 of @metamask/rpc-errors since there are no API breaking changes.
  • Update the pre-existing patch to target this new version.

Related issues

Fixes: #12240

Manual testing steps

See issue.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Nov 15, 2024
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 15, 2024 16:21
@matthewwalsh0 matthewwalsh0 requested a review from a team November 15, 2024 16:21
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 15, 2024 16:21
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/rpc-errors@6.4.0

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bc2b9ec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/86ed992f-9f2b-47a4-bdff-17faa07c8d96

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleepytanya
Copy link
Contributor

@sethkfman sethkfman added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 8fa867d Nov 15, 2024
@sethkfman sethkfman deleted the fix/transaction-reject-crash branch November 15, 2024 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: MetaMask app quits if dApp initiated transaction is rejected

5 participants