Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/json-rpc-engine@9.0.2 |
ed1fa42 to
6f2c53d
Compare
legobeat
left a comment
There was a problem hiding this comment.
patch-package is failing.
**ERROR** Failed to apply patch for package @metamask/preferences-controller
This happened because the patch file patches/@metamask+preferences-controller+11.0.0.patch could not be parsed.
If you just upgraded patch-package, you can try running:
patch -p1 -i patches/@metamask+preferences-controller+11.0.0.patch
npx patch-package @metamask/preferences-controller
Otherwise, try manually creating the patch file again.
If the problem persists, please submit a bug report:
https://github.com/ds300/patch-package/issues/new?title=Patch+file+parse+error&body=%3CPlease+attach+the+patch+file+in+question%3E
eacb5b8 to
0920582
Compare
rsolved cc @legobeat |
|
0920582 to
28ca838
Compare
|
28ca838 to
c19c471
Compare
|
…lim/default-rpc-feature
963f438 to
54af1c4
Compare
|
brianacnguyen
left a comment
There was a problem hiding this comment.
Approved with DS changes
|



Description
This PR refactors our network configuration to eliminate the use of multiple networks with the same ChainID but different RPC URLs. Instead, we are moving towards a setup where each network is uniquely identified by a distinct ChainID and can have multiple RPC URLs associated with it.
This PR includes three merge commits. The first primarily addresses the Network Controller upgrade, as outlined in issue #11229. The second commit contains the script for migrating the state to v21, and the third commit includes all the UI changes along with the fix for the e2e tests.
For more details, please refer to this .
related PRs:
Related issues
Fixes: #11229 #11232 #11234 #11233
Manual testing steps
Screenshots/Recordings
Before
After
https://drive.google.com/drive/folders/149Xji42k5of5Vl8nBlI0pFYFgPnWqILH?usp=drive_link
Pre-merge author checklist
Pre-merge reviewer checklist