feat: multi rpc modal by salimtb · Pull Request #11685 · MetaMask/metamask-mobile

salimtb · 2024-10-08T13:35:48Z

Description

This PR introduces the UI implementation for the Multi-RPC Modal, which is part of the broader initiative to support multiple RPC endpoints for networks. The modal allows users to view and select from multiple RPC options for a specific network, ensuring a smoother transition or switch between different endpoints.

UI Only: This PR focuses solely on the implementation of the UI. The modal is not yet integrated or functional in the application as it requires the upgrade of the Network Controller to version v21.

Related issues

Fixes:

Manual testing steps

this Modal is not called yet , it's require the network controller v21 to be used
the use of this modal will be done on this PR

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-08T13:36:01Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2024-10-08T14:01:42Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 9f18cd9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/40586aca-3e89-4fec-ac8d-4cd656c7634e

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-10-08T14:16:41Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 429cd76
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31c335bd-b770-49fb-b9fb-816f42ed4e2b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2024-10-08T14:34:01Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4b26e2c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/100c7026-0292-4caf-9793-c82c6c7c80e7

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

andreahaku

Hi, just a couple of suggestions for optimisation

app/components/Nav/Main/index.js

andreahaku

LGTM

github-actions · 2024-10-08T15:07:33Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 25fa281
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a624be17-4451-4b29-937c-fc785fc6ecbf

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

app/components/Nav/Main/index.js

app/components/Views/NetworkSelector/NetworkSelector.styles.ts

github-actions · 2024-10-08T17:47:00Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6c5cce2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e0282ada-8fa3-4227-8e71-0a95d7f59809

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

patches/@metamask+preferences-controller+11.0.0.patch

tommasini

LGTM! Thanks @salimtb !

resolved

github-actions · 2024-10-09T11:02:23Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6d761c4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ed40ab4b-f0d4-4365-b70d-9a8ce994d2a0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2024-10-09T11:15:05Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
42.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

andreahaku

LGTM

brianacnguyen · 2024-10-09T15:22:56Z

...mponent-library/components-temp/ListItemMultiSelectButton/ListItemMultiSelectButton.types.ts

+  showButtonIcon?: boolean;
+
+  buttonProps?: {
+    /**


@salimtb you should've imported the button props here

brianacnguyen · 2024-10-09T15:23:10Z

...ponents-temp/ListItemMultiSelectButton/__snapshots__/ListItemMultiSelectButton.test.tsx.snap

        "padding": 16,
        "position": "relative",
-        "width": "95%",
+        "width": "90%",


do not use percentage width

brianacnguyen

Design System did not approve this PR

feat: show toast

2cc2003

github-actions bot added the team-assets label Oct 8, 2024

salimtb force-pushed the salim/multi-rpc-ui-changes branch 3 times, most recently from f03f774 to 9f18cd9 Compare October 8, 2024 13:46

salimtb added the Run Smoke E2E label Oct 8, 2024

salimtb force-pushed the salim/multi-rpc-ui-changes branch from 9f18cd9 to 429cd76 Compare October 8, 2024 14:04

salimtb added Run Smoke E2E and removed Run Smoke E2E labels Oct 8, 2024

salimtb marked this pull request as ready for review October 8, 2024 14:29

salimtb requested a review from a team as a code owner October 8, 2024 14:29

salimtb requested a review from a team October 8, 2024 14:29

salimtb requested review from a team as code owners October 8, 2024 14:29

fix: add migration ui for network controller v21

4b26e2c

salimtb force-pushed the salim/multi-rpc-ui-changes branch from 429cd76 to 4b26e2c Compare October 8, 2024 14:32

salimtb added Run Smoke E2E and removed Run Smoke E2E labels Oct 8, 2024

andreahaku reviewed Oct 8, 2024

View reviewed changes

app/components/Nav/Main/index.js Show resolved Hide resolved

app/components/Nav/Main/index.js Outdated Show resolved Hide resolved

fix: fix PR comments

25fa281

salimtb removed the Run Smoke E2E label Oct 8, 2024

andreahaku previously approved these changes Oct 8, 2024

View reviewed changes

salimtb added the Run Smoke E2E label Oct 8, 2024

EtherWizard33 previously approved these changes Oct 8, 2024

View reviewed changes

app/components/Nav/Main/index.js Outdated Show resolved Hide resolved

app/components/Views/NetworkSelector/NetworkSelector.styles.ts Show resolved Hide resolved

salimtb removed the Run Smoke E2E label Oct 8, 2024

salimtb force-pushed the salim/multi-rpc-ui-changes branch from 5981720 to 6c5cce2 Compare October 8, 2024 17:45

salimtb added Run Smoke E2E and removed Run Smoke E2E labels Oct 8, 2024

tommasini reviewed Oct 8, 2024

View reviewed changes

patches/@metamask+preferences-controller+11.0.0.patch Outdated Show resolved Hide resolved

fix: fix patch

054ac33

salimtb added Run Smoke E2E and removed Run Smoke E2E labels Oct 9, 2024

tommasini approved these changes Oct 9, 2024

View reviewed changes

Merge branch 'main' into salim/multi-rpc-ui-changes

6d761c4

salimtb added the Run Smoke E2E label Oct 9, 2024

salimtb removed the request for review from a team October 9, 2024 11:12

salimtb requested review from brianacnguyen and removed request for brianacnguyen October 9, 2024 11:47

EtherWizard33 self-requested a review October 9, 2024 11:50

EtherWizard33 approved these changes Oct 9, 2024

View reviewed changes

salimtb added this pull request to the merge queue Oct 9, 2024

Merged via the queue into main with commit ea3948c Oct 9, 2024

salimtb deleted the salim/multi-rpc-ui-changes branch October 9, 2024 12:05

github-actions bot locked and limited conversation to collaborators Oct 9, 2024

andreahaku reviewed Oct 9, 2024

View reviewed changes

brianacnguyen reviewed Oct 9, 2024

View reviewed changes

gauthierpetetin added the release-7.34.0 label Oct 10, 2024

Uh oh!

Conversation

salimtb commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 8, 2024

Uh oh!

github-actions bot commented Oct 8, 2024

Bitrise

Uh oh!

github-actions bot commented Oct 8, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Oct 8, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

andreahaku left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

andreahaku left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 8, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 8, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

tommasini left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 9, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented Oct 9, 2024

Quality Gate passed

Uh oh!

andreahaku left a comment

Choose a reason for hiding this comment

Uh oh!

brianacnguyen Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

brianacnguyen Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

brianacnguyen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

salimtb commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 8, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 8, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 8, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 9, 2024 •

edited by metamaskbot

Loading