Merged
Conversation
danjm
force-pushed
the
Version-6.7.2-gasLimitFix
branch
from
e755843 to
0d5858f
Compare
whymarrh
suggested changes
Jul 3, 2019
| gasLimit: this.props.customGasLimit, | ||
| } | ||
| this.changeGasPrice = debounce(this.changeGasPrice, 500) | ||
| this.changeGasLimit = debounce(this.changeGasLimit, 500) |
Contributor
There was a problem hiding this comment.
Can we use the property syntax for the debounce? That is, wrap the property value in the debounce call directly. If we can remove theses lines we can move the state to a property as well and remove the constructor.
|
|
||
|
|
||
| const transaction = selectedAddressTxList.find(({ id }) => id === (Number(paramsTransactionId) || transactionId)) | ||
| console.log('!!! * transaction', transaction) |
| value: amount, | ||
| data, | ||
| } = txParams | ||
| } = transaction && transaction.txParams || txParams |
Contributor
There was a problem hiding this comment.
Can we express this instead with a ternary?
Contributor
|
I'm testing out 8e967aa locally now |
danjm
added
N04-needsQA
and removed
DO-NOT-MERGE
Gudahtt
requested changes
Jul 3, 2019
| } | ||
|
|
||
| onChangeGasPrice = (e) => { | ||
| this.setState({ gasPrice: e.target.value }) |
Member
There was a problem hiding this comment.
Should e.target.value be converted to a Number here?
Edit: Likewise for onChangeGasLimit above
danjm
force-pushed
the
Version-6.7.2-gasLimitFix
branch
from
989c873 to
2ef4078
Compare
danjm
force-pushed
the
Version-6.7.2-gasLimitFix
branch
from
2ef4078 to
1b7f62f
Compare
Collaborator
Collaborator
This was referenced Jul 3, 2019
tmashuang
approved these changes
Jul 3, 2019
danjm
added a commit
that referenced
this pull request
Jul 4, 2019
* Introduce delay for eth_estimateGas calls with in test * Add test that fails when gas estimates of contract method calls without gas are too high. * Get transaction gas data from unApprovedTxs instead of confirmTransaction * Fix selection of gas data in gas-modal-page-container.container * Lint changes related to Version-6.7.2-gasLimitFix * Fix e2e tests on Version-6.7.2-gasLimitFix * Fix unit and integration tests for changes from Version-6.7.2-gasLimitFix * more e2e fixes * Add assertions for transaction values on confirm screen * Fix display of transaction amount on confirm screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.