Rename transactionHash property to hash in the persisted transaction metadata#1620
Merged
vinistevam merged 5 commits intomainfrom Sep 12, 2023
Merged
Conversation
vinistevam
force-pushed
the
refactor/1077-rename-transactionHash-hash
branch
3 times, most recently
from
202bc9e to
876616b
Compare
legobeat
changed the title
vinistevam
force-pushed
the
refactor/1077-rename-transactionHash-hash
branch
from
876616b to
012567b
Compare
packages/transaction-controller/src/EtherscanRemoteTransactionSource.test.ts
Outdated
Show resolved
Hide resolved
vinistevam
force-pushed
the
refactor/1077-rename-transactionHash-hash
branch
from
012567b to
9075f5c
Compare
Contributor
|
Same question as for #1624 (comment) |
Contributor
Author
Thanks again for pointing it out. 🙏 |
matthewwalsh0
previously approved these changes
Aug 30, 2023
vinistevam
force-pushed
the
refactor/1077-rename-transactionHash-hash
branch
3 times, most recently
from
22ab62c to
66db778
Compare
matthewwalsh0
previously approved these changes
Sep 5, 2023
vinistevam
force-pushed
the
refactor/1077-rename-transactionHash-hash
branch
from
66db778 to
185843f
Compare
matthewwalsh0
approved these changes
Sep 8, 2023
OGPoyraz
approved these changes
Sep 12, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…metadata (#1620) ## Explanation Rename the `transactionHash` property to `hash` in the persisted transaction metadata as part of the unification initiative between the core and extension. The following task will take place to handle the migration and adoption of the patch/release. ## References Fixes MetaMask/MetaMask-planning#1077 ## Changelog ### `@metamask/transaction-controller` - **BREAKING**: rename the `transactionHash` property to `hash` in the persisted `TransactionMeta`.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…metadata (#1620) ## Explanation Rename the `transactionHash` property to `hash` in the persisted transaction metadata as part of the unification initiative between the core and extension. The following task will take place to handle the migration and adoption of the patch/release. ## References Fixes MetaMask/MetaMask-planning#1077 ## Changelog ### `@metamask/transaction-controller` - **BREAKING**: rename the `transactionHash` property to `hash` in the persisted `TransactionMeta`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Rename the
transactionHashproperty tohashin the persisted transaction metadata as part of the unification initiative between the core and extension.The following task will take place to handle the migration and adoption of the patch/release.
References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/1077
Changelog
@metamask/transaction-controllertransactionHashproperty tohashin the persistedTransactionMeta.Checklist