Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented May 24, 2022

This PR is similar to MetaMask/action-create-release-pr#85, but as @mcmire brought up, only patching this in action-create-release-pr creates differences between that package and other packages, such as action-publish-release.

This adds a third parameter to the getWorkspaceLocations function, which specifies whether you want to do a recursive search. When this is enabled, it:

  1. Loads the package.json for each package.
  2. Checks if the package is a monorepo (i.e., whether it contains a workspaces field).
  3. Recursively calls getWorkspaceLocations for monorepo packages.

Since this is a potentially breaking change (validating package.json files in packages), the functionality is disabled by default.

@Mrtenz Mrtenz requested a review from mcmire May 24, 2022 12:10
@Mrtenz Mrtenz requested a review from a team as a code owner May 24, 2022 12:10
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit 568ffc2 into main May 27, 2022
@Mrtenz Mrtenz deleted the mz/recursive branch May 27, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants