Skip to content

Retry getting the release PR number on a timeout #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rekmarks merged 2 commits into from
Jun 28, 2022
Merged

Retry getting the release PR number on a timeout #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbf8636
Retry getting the release PR number on a timeout
rekmarks Jun 28, 2022
c17ac54
Apply suggestions from code review
rekmarks Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion scripts/create-release-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,21 @@ fi

if [[ -n $ARTIFACTS_DIR_PATH ]]; then
# Write PR number to file so that it can be uploaded as an artifact
PR_NUMBER=$(gh pr view --json number | jq '.number')

# Retry getting the number on a timeout in case GitHub is slow to create the PR
PR_NUMBER=''
for i in {1..7} # 6 + 1 times total
do
PR_NUMBER=$(gh pr view --json number | jq '.number')
if [[ -n $PR_NUMBER ]]; then
break
fi

# sleep 6 times for 10 seconds each, for a total of 60 seconds
if (( i < 7 )); then
sleep 10
fi
done

if [[ -z $PR_NUMBER ]]; then
echo 'Error: "gh pr view" did not return a PR number.'
Expand Down