fix updatePackageChangelog to not to throw when there are unreleased changes #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turns null and no unreleased changes
mikesposito
approved these changes
Aug 20, 2024
Gudahtt
added a commit
to MetaMask/ppom-validator
that referenced
this pull request
Sep 5, 2025
Update the action `action-create-release-pr` to v3.0.1, which includes a bug fix impacting the next release (MetaMask/action-create-release-pr#139) The v2 updated included no relevant breaking changes (just a Node.js minimum version bump), but the v3 update changed the formatting of the changelog to use Prettier. All changelog commands have been updated to use Prettier formatting, and the changelog has been reformatted. Changelog: https://github.com/MetaMask/action-create-release-pr/blob/main/CHANGELOG.md#301 I didn't update as far as v4 of this action because that would have required further changes (namely the update to Prettier v3).
Gudahtt
added a commit
to MetaMask/ppom-validator
that referenced
this pull request
Sep 5, 2025
Update the action `action-create-release-pr` to v3.0.1, which includes a bug fix impacting the next release (MetaMask/action-create-release-pr#139) The v2 updated included no relevant breaking changes (just a Node.js minimum version bump), but the v3 update changed the formatting of the changelog to use Prettier. All changelog commands have been updated to use Prettier formatting, and the changelog has been reformatted. Changelog: https://github.com/MetaMask/action-create-release-pr/blob/main/CHANGELOG.md#301 I didn't update as far as v4 of this action because that would have required further changes (namely the update to Prettier v3).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, the create-release-pr action is terminated with an error message ("updateChangelog" returned an empty value for package ...) and the release candidate is not created if the updateChangelog call does not return any new entries, but there are unreleased changes.
The error should be triggered only if both of the following are true:
References
updateChangelogdoes not return any new entries #138