Skip to content

devDeps: @metamask/eslint-config* from v9 to v12 #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
legobeat merged 10 commits into from
Oct 20, 2023
Merged

devDeps: @metamask/eslint-config* from v9 to v12 #120

legobeat merged 10 commits into from
Oct 20, 2023

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 20, 2023

@legobeat legobeat force-pushed the devDeps-eslint-configs-12 branch from 199b029 to af69121 Compare October 20, 2023 02:13
@socket-security
Copy link

socket-security bot commented Oct 20, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-promise 6.1.1 None +36 8.24 MB eslint-community-bot
eslint-plugin-n 15.7.0 filesystem +45 9.35 MB weiran.zsd
@metamask/eslint-config-jest 9.0.0...12.1.0 None +65/-107 86.3 MB metamaskbot
@metamask/eslint-config-typescript 9.0.1...12.1.0 None +53/-106 81.8 MB metamaskbot
@metamask/eslint-config-nodejs 9.0.0...12.1.0 None +46/-93 9.44 MB metamaskbot
eslint-config-prettier 8.2.0...8.10.0 None +36/-39 8.2 MB lydell
semver 7.3.5...7.5.4 None +0/-0 93.4 kB npm-cli-ops
@types/semver 7.3.6...7.5.4 None +0/-0 23.2 kB types
@vercel/ncc 0.28.3...0.38.1 environment +0/-0 16.6 MB vercel-release-bot
@typescript-eslint/eslint-plugin 4.22.0...5.62.0 None +52/-54 81.8 MB jameshenry
@typescript-eslint/parser 4.22.0...5.62.0 None +46/-51 78.7 MB jameshenry
@types/node 14.14.41...16.18.59 None +0/-0 3.51 MB types
eslint-plugin-prettier 3.4.0...4.2.1 None +36/-39 8.23 MB jounqin
eslint-plugin-jsdoc 36.1.1...39.9.1 None +40/-44 10.6 MB gajus
eslint-plugin-import 2.22.1...2.26.0 None +99/-80 14.1 MB ljharb
eslint 7.24.0...8.51.0 environment +35/-38 8.18 MB eslintbot
eslint-plugin-jest 24.3.5...27.4.2 None +64/-55 86.3 MB simenb
typescript 4.3.5...4.8.4 None +0/-0 68.8 MB typescript-bot

🚮 Removed packages: @metamask/[email protected], [email protected]

@socket-security
Copy link

socket-security bot commented Oct 20, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], [email protected], [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat force-pushed the devDeps-eslint-configs-12 branch from af69121 to f785bec Compare October 20, 2023 02:19
@legobeat
Copy link
Contributor Author

legobeat commented Oct 20, 2023 

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

@legobeat legobeat mentioned this pull request Oct 20, 2023
Merged
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Oct 20, 2023
@legobeat legobeat force-pushed the devDeps-eslint-configs-12 branch from 34ddc38 to 100766c Compare October 20, 2023 02:41
@legobeat
Copy link
Contributor Author

legobeat commented Oct 20, 2023 

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

no readme ok

@legobeat legobeat marked this pull request as ready for review October 20, 2023 02:42
@legobeat legobeat requested a review from a team as a code owner October 20, 2023 02:42
@legobeat legobeat requested a review from Mrtenz October 20, 2023 02:44
@legobeat legobeat force-pushed the devDeps-eslint-configs-12 branch from 100766c to 0b26e61 Compare October 20, 2023 03:10
@legobeat
update eslintrc
3e0db28
@legobeat
address nullish-coalescing & template strings lint
3e6decc
@legobeat
lint:fix
1029ad2
@legobeat
devDeps: @vercel/ncc@^0.28.3->@0.38.1
166362c 
Fixes build error:

    yarn run v1.22.19
    $ yarn build:clean && yarn build:tsc && yarn build:ncc
    $ yarn rimraf 'lib/*' 'dist/*'
    $ /home/user/dev/mm/action-create-release-pr/node_modules/.bin/rimraf 'lib/*' 'dist/*'
    $ tsc --project tsconfig.build.json
    $ ncc build lib/index.js --out dist
    ncc: Version 0.29.2
    ncc: Compiling file index.js into CJS
    Error: error:0308010C:digital envelope routines::unsupported
        at new Hash (node:internal/crypto/hash:69:19)
        at Object.createHash (node:crypto:133:10)
        at hashOf (/home/user/dev/mm/action-create-release-pr/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1855992)
        at ncc (/home/user/dev/mm/action-create-release-pr/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1860404)
        at runCmd (/home/user/dev/mm/action-create-release-pr/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:55081)
        at 819 (/home/user/dev/mm/action-create-release-pr/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:51698)
        at __webpack_require__ (/home/user/dev/mm/action-create-release-pr/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:59006)
        at /home/user/dev/mm/action-create-release-pr/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:59218
        at /home/user/dev/mm/action-create-release-pr/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:59279
        at Object.<anonymous> (/home/user/dev/mm/action-create-release-pr/node_modules/@vercel/ncc/dist/ncc/cli.js:8:28) {
      opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
      library: 'digital envelope routines',
      reason: 'unsupported',
      code: 'ERR_OSSL_EVP_UNSUPPORTED'
    }
    error Command failed with exit code 1.
@legobeat
update dist
acc3527
@legobeat
add test
513b144
@legobeat legobeat force-pushed the devDeps-eslint-configs-12 branch from 0b26e61 to 513b144 Compare October 20, 2023 03:15
@legobeat legobeat mentioned this pull request Oct 20, 2023
Merged
@legobeat legobeat merged commit 033cee1 into MetaMask:main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @Mrtenz