BREAKING: Format changelog using Prettier #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
MajorLift
requested changes
Oct 13, 2023
MajorLift
left a comment
MajorLift
left a comment
There was a problem hiding this comment.
Could we add a BREAKING changelog entry in the PR description (and eventual commit message) detailing the required build script changes, and any other considerations to introducing the updates made in this PR?
Otherwise looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaMask/auto-changelog#155 adds a method to format changelogs using Prettier. I've enabled this option here.
This is a breaking change, since it will change the default formatting of the changelog in new release PRs. Packages updating to the next version of this package should simultaneously enable the
--prettierflag onauto-changelog.Breaking changes
auto-changelogshould be updated to run with the--prettierflag.