Skip to content

Check for workspace:^ before replacing the version in package.json #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mrtenz merged 4 commits into from
Apr 3, 2023
Merged

Check for workspace:^ before replacing the version in package.json #108

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a046ee6
Check for presence of `workspace:^` in package.json before replacing …
Mrtenz Apr 3, 2023
dcca631
Add a step to use Node.js version specified in .nvmrc
Mrtenz Apr 3, 2023
292de07
Update build files
Mrtenz Apr 3, 2023
ed23cc7
Check if dependency starts with 'workspace:'
Mrtenz Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build-lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version-file: '.nvmrc'
Comment on lines +13 to +15
Copy link
Member Author

@Mrtenz Mrtenz Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package never had a proper Node.js setup step. The default Node.js version now seems to be 18, causing installation of dependencies to fail.

- run: yarn install --frozen-lockfile
- run: yarn setup:postinstall
- run: yarn build
Expand Down
8 changes: 5 additions & 3 deletions src/package-operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,11 @@ function getUpdatedDependencyField(
const newVersionRange = `^${newVersion}`;
return Object.keys(dependencyObject).reduce(
(newDeps: Record<string, string>, packageName) => {
newDeps[packageName] = packagesToUpdate.has(packageName)
? newVersionRange
: dependencyObject[packageName];
newDeps[packageName] =
packagesToUpdate.has(packageName) &&
dependencyObject[packageName] !== 'workspace:^'
Copy link
Member

@Gudahtt Gudahtt Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Perhaps we could see if it starts with workspace: instead? We usually use the ^ range but the problem should apply for any type of range used.

Copy link
Member Author

@Mrtenz Mrtenz Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, updated!

? newVersionRange
: dependencyObject[packageName];

return newDeps;
},
Expand Down