-
Notifications
You must be signed in to change notification settings - Fork 38
Add support for the test suite on monsoon 3 #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update the rose-stem configuration files to simplify the process of running the test suite on the monsoon 3 partition of EXD.
james-bruten-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removing the duplicated directives and the commented out lines
|
|
||
| {# Platform Generic Groups #} | ||
| {% if site_vars.launch_platform == "azspice" %} | ||
| {# {% if site_vars.launch_platform == "azspice" %} #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to just remove this and the endif. Maybe the lines below need unindenting too?
| HYPERTHREADS = 1 | ||
| CORES_PER_NODE = 128 | ||
| NUMA_REGIONS_PER_NODE = 2 | ||
| [[[directives]]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get Rid
james-bruten-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also good, cheers
Update the rose-stem configuration files to simplify the process of running the test suite on the monsoon 3 partition of EXD.
PR Summary
Sci/Tech Reviewer: @james-bruten-mo
Code Reviewer: @r-sharp
Similar to trac ticket #779 and MetOffice/lfric_apps#166, this adds support for the test suites on monsoon 3 using github PATs to access the repositories.
Code Quality Checklist
Testing
trac.log
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review