jelf adjoint test tolerance namelist variable

[tom-j-h]

PR Summary

Sci/Tech Reviewer: @mo-joshuacolclough
Code Reviewer: @stevemullerworth

Allows different test strictness when running different optional configurations. Necessary for follow-on PRs.

• blocks Align jedi_lfric_tests linear model/adjoint testing to adjoint_tests and linear_model #156
• closes Allow jelf adjoint test tolerance to be set via a namelist variable #124

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Core rose-stem suite
• If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - jelf_adjoint_test_tolerance_nml-developer/run1

Suite Information

Item	Value
Suite Name	jelf_adjoint_test_tolerance_nml-developer/run1
Suite User	tom.hill
Workflow Start	2026-01-30T10:07:15
Groups Run	developer

Dependency	Reference	Main Like
casim	MetOffice/[email protected]	True
jules	MetOffice/[email protected]	True
lfric_apps	tom-j-h/lfric_apps@tlad_boundary_layer	False
lfric_core	MetOffice/lfric_core@bbb3d8a	True
moci	MetOffice/[email protected]	True
SimSys_Scripts	MetOffice/[email protected]	True
socrates	MetOffice/[email protected]	True
socrates-spectral	MetOffice/[email protected]	True
ukca	MetOffice/[email protected]	True

Task Information

✅ succeeded tasks - 1106

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[mo-joshuacolclough]

Looking at the diff in the description, given that those changes go in first - passes sci/tech review. Passing to @stevemullerworth

[tom-j-h]

@mo-joshuacolclough asked me to tick the SR boxes because he couldn't!

[tom-j-h]

Had neglected to add an upgrade macro originally, apologies. Now added. Test branch: https://github.com/tom-j-h/lfric_apps/tree/jelf_adjoint_test_tolerance_nml-test

[ss421]

I can confirm that this does not impact JEDI testing so there is nothing further to do on that side.