Merged
Conversation
Defining __all__ also fixes flake8 unused import errors.
This fixes the flake8 errors caused by "import *" syntax.
Replacing \param with :param fixes flake8 warnings caused by \p being treated as an escape sequence.
Contributor
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This merge request makes a number of mainly cosmetic changes to the
pygeodiffdirectory to fix errors and warnings raised by theflake8linting software. This removes ugly warning underlines in IDEs that report on flake8.The fixes are:
__all__and replacingimport *syntax..flake8config with max-line-length of 100, shortening some lines and using# noqawhere they can't be shortened.:param input_file:.To test
The result of the fixes can be seen by running
flake8 pygeodiffin the project root directory in both themainandflake8-fixesbranches.The remaining errors in the
flake8-fixesbranch are not cosmetic, so have been left.