Merged
Conversation
PeterPetrik
force-pushed
the
iss_136_context
branch
from
93ea52e to
4969e2e
Compare
PeterPetrik
force-pushed
the
iss_136_context
branch
from
472fc47 to
21dee14
Compare
PeterPetrik
force-pushed
the
iss_136_context
branch
from
21dee14 to
add4465
Compare
alexbruy
approved these changes
Jun 6, 2022
Contributor
alexbruy
left a comment
alexbruy
left a comment
There was a problem hiding this comment.
Looks ok for me, but I'm not very familiar with geodiff and might miss some details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #136
!! API BREAK !!
Introduces new Geodiff Context, currently only having logger instance. All the C-API is now changed!
Also temporary we have less error logs from sqlite (no global callback), we need to implement more detailed sqlite3 logging on various places instead (#135)