fix: Ensure connection parameters are update to the SSH tunnel host and port #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilofuchs
approved these changes
Jan 13, 2026
Contributor
danilofuchs
left a comment
danilofuchs
left a comment
There was a problem hiding this comment.
Oh sorry, missed that when refactoring
Contributor
|
Wondering how the test cases did not catch that? |
edgarrmondragon
force-pushed
the
fix/set-tunnel-connection-params
branch
2 times, most recently
from
1ae7537 to
bd390b4
Compare
Member
Author
The integration tests still connect to the Postgres since it's available without having to go through the tunnel. |
…and port - Bug introduced by #717 Signed-off-by: Edgar Ramírez Mondragón <[email protected]>
edgarrmondragon
force-pushed
the
fix/set-tunnel-connection-params
branch
from
6cd3e66 to
f682681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @danilofuchs