Conversation
|
Although... but LTCatt has rejected some of these features. |
|
不会加入非常复杂的内容，只有简单的查看（不会有非常详细的信息，比如存档内容、在线资源指向……）、删除、另存为什么的…… |
Waiting for your good news. |
|
我自己应该不会考虑添加这些功能……不过可以加进 PR Collection 啥的（ |
|
刚发现 7965ca8 干爆了我 PR Collection |
|
So beautiful!!! I like that. Lightweight and practical. Review comments will be provided later (if available). |
This comment was marked as resolved.
This comment was marked as resolved.
资源包显示图标 部分图标修改 部分文案修改
3gf8jv4dv
left a comment
3gf8jv4dv
left a comment
There was a problem hiding this comment.
When I click on the resource pack
程序出现未知错误：Could not find a part of the path '*:\PCL\.minecraft\versions\*\PCL\Resourcepacks\'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.Directory.Delete(String fullPath, String userPath, Boolean recursive, Boolean checkHost)
at PCL.PageVersionResourcePack.LoadFileList()
at PCL.PageVersionResourcePack.Reload()
at PCL.PageVersionResourcePack.PageSetupLaunch_Loaded(Object sender, RoutedEventArgs e)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
at System.Windows.BroadcastEventHelper.BroadcastEvent(DependencyObject root, RoutedEvent routedEvent)
at System.Windows.BroadcastEventHelper.BroadcastLoadedEvent(Object root)
at MS.Internal.LoadedOrUnloadedOperation.DoWork()
at System.Windows.Media.MediaContext.FireLoadedPendingCallbacks()
at System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
at System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
错误类型：System.IO.DirectoryNotFoundException
3gf8jv4dv
left a comment
3gf8jv4dv
left a comment
There was a problem hiding this comment.
Some opinions.
After copying the screenshot, no screenshot is seen in the Win+V clipboard interface. However, the screenshot function of some software can be used to view the corresponding screenshot on the above interface after taking the screenshot. Is it possible to implement it here?
For each screenshot in the screenshot interface, can you add rounded corners around the preview? The current effect looks a bit abrupt compared to the UI elements.
Plain Craft Launcher 2/Pages/PageVersion/PageVersionScreenshot.xaml
Outdated
Show resolved
Hide resolved
….xaml Co-authored-by: 3gf8jv4dv <[email protected]>
|
When I try to add rounded corners around the picture, the UI becomes strange.
And there seems some issues with windows clipboard, it does not work very well sometimes. |
|
资源包和光影包其实可以完全按照 Mod 页面的方式来，它们也可以获取到 CF/Modrinth 上的工程，所以也可以跳转到详情页面以及更新啥的。 |
思考了下，决定改一个 ModLocalComp.vb 代替 ModMod.vb，这样弄一个通用的工程资源查看就可以减少重复造的轮子（
给个简单的查看问题也不大？ Edit: 好像可行性非常大，等我在社区版测试下看看 |
|
Mod/资源包/光影包 的代码确实建议合并到一个 Page，不然会重复三次…… |
|
目前效果
此外，此 PR 建议在资源下载合并之后合并，因为缺少很多必要的前置（比如标签、工程类型、页面跳转） |
|
此功能在 CE 测试时发现了 CurrentLoader 不更新问题，比较棘手，正在寻找更好实现方法…… |
|
可以参考 2.10.0 中的 PageComp 的形式统一 Mod/资源包/光影包 的代码……（ |
|
目前有个问题。光影包和材质包可以以文件夹的形式存在，但是目前只有基于文件的资源逻辑。是否需要考虑兼容文件夹形式存在的资源？🤔 |
这种感觉可以不管…… |
6 participants
施工中