Added registry source, and package publish/install #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongde88
commented
Jan 11, 2022
hongde88
commented
- Added registry source to mdctl-packages.
- Added package publish/install to mdctl-cli.
gastonrobledo
requested changes
Jan 21, 2022
| let srcClient | ||
|
|
||
| if (source === 'registry') { | ||
| if (!isSet(registryUrl)) { |
Collaborator
There was a problem hiding this comment.
why not adding this checking inside the Registry class?
Author
There was a problem hiding this comment.
Good catch there. I actually just realized that I added that check inside Registry class already. Let me remove that check from publish.js.
Collaborator
|
@hongde88 we could also add some tests for these changes. |
Author
|
@gastonrobledo I'm wrapping up some unit tests for my changes and will push them later. Thanks! |
gastonrobledo
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.