Fix issues with RLOGServer #248
Open
Ruthie-FRC wants to merge 4 commits intoMechanical-Advantage:2027from
Open
Fix issues with RLOGServer #248Ruthie-FRC wants to merge 4 commits intoMechanical-Advantage:2027from
Ruthie-FRC wants to merge 4 commits intoMechanical-Advantage:2027from
Conversation
Contributor
Author
|
@jwbonner sorry for the delay, but I believe this resolves the issue that I said I would work on. just tagging you in case you missed this, if you didn't, I'm so sorry to bother you. |
Contributor
Author
|
is this still relevant? |
Contributor
Author
|
#190 this should resolve? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
RLOGServerclass to improve resource management by implementing theAutoCloseableinterface, ensuring that server threads and resources can be properly closed. It also updates the copyright year.resolves #190
Resource management improvements:
RLOGServernow implementsAutoCloseable, allowing it to be used in try-with-resources statements and ensuring proper cleanup of resources. Theend()method now delegates to the newclose()method. (akit/src/main/java/org/littletonrobotics/junction/rlog/RLOGServer.java) [1] [2]ServerThreadclass also implementsAutoCloseable, providing aclose()method for thread resource management. (akit/src/main/java/org/littletonrobotics/junction/rlog/RLOGServer.java) [1] [2]Other changes:
RLOGServer.java. (akit/src/main/java/org/littletonrobotics/junction/rlog/RLOGServer.java)