Skip to content

Use wpilib's builtin StructGenerator instead of custom RecordStruct#237

Open
Daniel1464 wants to merge 1 commit intoMechanical-Advantage:mainfrom
Daniel1464:replaceRecordStruct
Open

Use wpilib's builtin StructGenerator instead of custom RecordStruct#237
Daniel1464 wants to merge 1 commit intoMechanical-Advantage:mainfrom
Daniel1464:replaceRecordStruct

Conversation

@Daniel1464
Copy link

WPILib now has a struct generator class that already generates structs for record classes, so there's no need for akit to still have its own.

@jwbonner
Copy link
Member

Does the WPILib StructGenerator support enum fields nested within a record? These lines seem to suggest not, though perhaps I've missed something. Otherwise this looks OK to me, but maintaining that support would be a prerequisite to switching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants