test: enable BLE tests with comprehensive fakes and stubs

.claude/CLAUDE.md

@@ -0,0 +1 @@
+../AGENTS.md

.github/workflows/build-firmware.yml

@@ -102,7 +102,7 @@ jobs:
 
       - name: Upload log hash dictionary
         uses: Noelware/s3-action@2.3.1
-        if: ${{ github.event_name == 'push' }}
+        if: ${{ github.event_name == 'push' && github.repository == 'coredevices/PebbleOS' }}
         with:
           access-key-id: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
           secret-key: ${{ secrets.LOG_HASH_BUCKET_SECRET }}

.github/workflows/build-prf.yml

@@ -108,7 +108,7 @@ jobs:
 
       - name: Upload log hash dictionary
         uses: Noelware/s3-action@2.3.1
-        if: ${{ github.event_name == 'push' }}
+        if: ${{ github.event_name == 'push' && github.repository == 'coredevices/PebbleOS' }}
         with:
           access-key-id: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
           secret-key: ${{ secrets.LOG_HASH_BUCKET_SECRET }}

.github/workflows/release.yml

@@ -186,6 +186,7 @@ jobs:
 
       - name: Upload log hash dictionary
         uses: Noelware/s3-action@2.3.1
+        if: ${{ github.repository == 'coredevices/PebbleOS' }}
         with:
           access-key-id: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
           secret-key: ${{ secrets.LOG_HASH_BUCKET_SECRET }}

.gitlint

@@ -4,9 +4,16 @@ ignore-merge-commits=false
 ignore-fixup-commits=false
 ignore-fixup-amend-commits=false
 ignore-squash-commits=false
+regex-style-search=true
 
 [title-match-regex]
-regex=[a-z0-9/]+: .*
+# Format: "area: description" where area is either:
+# - A path with at least one / (e.g., fw/drivers/hrm, third_party/nonfree)
+# - One of the known short areas: ci, treewide, platform, sdk, tools, resources,
+#   docs, waftools, settings, libc, tests, notifications, build, wscript, fw,
+#   third_party, ancs, compositor, console, kernel, health
+# Conventional commit types like feat:, fix:, chore: are NOT allowed.
+regex=^([a-z0-9_]+/[a-z0-9_/]*|ci|treewide|platform|sdk|tools|resources|docs|waftools|settings|libc|tests|notifications|build|wscript|fw|third_party|ancs|compositor|console|kernel|health|gitlint|readme|requirements|python_libs|pbl-tool|pbl|moddable|libutil|iconography|gitignore|capabilities|asterix|activity|accel): .*
 
 [title-max-length]
 line-length=100

AGENTS.md

@@ -0,0 +1,49 @@
+# PebbleOS
+
+PebbleOS is the operating system running on Pebble smartwatches.
+
+## Organization
+
+- `docs`: project documentation
+- `python_libs`: tools used in multiple areas, e.g. log dehashing, console, etc.
+- `resources`: firmware resources (icons, fonts, etc.)
+- `sdk`: application SDK generation files
+- `src`: firmware source
+- `tests`: tests
+- `third_party`: third-party code in git submodules, also includes glue code
+- `tools`: a variety of tools or scripts used in multiple areas, from build
+  system, tests, etc.
+- `waftools`: scripts used by the build system
+
+## Code style
+
+- clang-format for C code
+
+## Firmware development
+
+- Configure: `./waf configure --board BOARD_NAME`
+
+  - Board names can be obtained from `./waf --help`
+  - `--release` enables release mode
+  - `--mfg` enables manufacturing mode
+  - `--qemu` enables QEMU mode
+
+- Build main firmware: `./waf build`
+- Build recovery firmware (PRF): `./waf build_prf`
+- Run tests: `./waf test`
+
+## Git rules
+
+Main rules:
+
+- Commit using `-s` git option, so commits have `Signed-Off-By`
+- Always indicate commit is co-authored by Claude
+- Commit in small chunks, trying to preserve bisectability
+- Commit format is `area: short description`, with longer description in the
+  body if necessary
+- Run `gitlint` on every commit to verify rules are followed
+
+Others:
+
+- If fixing Linear or GitHub issues, include in the commit body a line with
+  `Fixes XXX`, where XXX is the issue number.

src/fw/comm/ble/gatt_client_subscriptions.c

@@ -618,7 +618,8 @@ static BTErrno prv_subscribe(BLECharacteristic characteristic_ref,
       .att_handle = att_handle,
     };
     // Prepend to the list of subscriptions of the connection:
-    ListNode *head = &connection->gatt_subscriptions->node;
+    ListNode *head = connection->gatt_subscriptions ?
+                       &connection->gatt_subscriptions->node : NULL;
     connection->gatt_subscriptions =
                              (GATTClientSubscriptionNode *) list_prepend(head, &subscription->node);
 

src/fw/comm/ble/kernel_le_client/ppogatt/ppogatt.c

@@ -758,8 +758,23 @@ static void prv_handle_meta_read(PPoGATTClient *client, const uint8_t *value,
                                  size_t value_length, BLEGATTError error) {
   PBL_ASSERTN(client->state == StateDisconnectedReadingMeta);
   if (error != BLEGATTErrorSuccess) {
-    // GATT read failed - this is retriable since the mobile app may not be ready yet
-    goto handle_retriable_error;
+    // Check if this is a permanent error that should not be retried
+    // Permanent errors include: InvalidHandle, ReadNotPermitted, InvalidPDU,
+    // InsufficientAuthentication/Authorization/Encryption, AttributeNotFound, etc.
+    // These errors indicate that the operation cannot succeed through retrying.
+    // Timeout and resource errors are retriable since the remote might recover.
+    switch (error) {
+      case BLEGATTErrorSuccess:
+        break;
+      // Retriable errors - remote might recover:
+      case BLEGATTErrorPrepareQueueFull:
+      case BLEGATTErrorInsufficientResources:
+      case BLEGATTErrorRequestTimeOut:
+        goto handle_retriable_error;
+      // Permanent errors - delete client immediately:
+      default:
+        goto handle_error;
+    }
   }
   if (value_length < sizeof(PPoGATTMetaV0)) {
     goto handle_error;
@@ -844,6 +859,10 @@ static void prv_handle_meta_read(PPoGATTClient *client, const uint8_t *value,
     return;
   }
 
+  // Subscribe failed - this is a permanent error, delete the client
+  PBL_LOG_ERR("Failed to subscribe to PPoGATT data characteristic: err=%x", e);
+  goto handle_error;
+
 handle_retriable_error:
   // GATT read failed - schedule a retry if we haven't exceeded the max retry count
   if (++client->meta_read_retries < PPOGATT_META_READ_RETRY_COUNT_MAX) {

src/fw/drivers/hrm/as7000/as7000.c

@@ -514,7 +514,6 @@ static void prv_disable(HRMDevice *dev) {
       WTF;
   }
   led_disable(LEDEnablerHRM);
-  analytics_stopwatch_stop(ANALYTICS_DEVICE_METRIC_HRM_ON_TIME);
 }
 
 // NOTE: the caller must hold the device's state lock
@@ -525,7 +524,6 @@ static void prv_enable(HRMDevice *dev) {
 
   } else if (dev->state->enabled_state == HRMEnabledState_Disabled) {
     led_enable(LEDEnablerHRM);
-    analytics_stopwatch_start(ANALYTICS_DEVICE_METRIC_HRM_ON_TIME, AnalyticsClient_System);
 
     // Enable the device and schedule a timer callback for when we can start communicating with it.
     gpio_output_set(&dev->en_gpio, true);