Skip to content

Merge benchmarks by Russell and Yuxuan into Development#6

Merged
McLavish merged 29 commits into
developmentfrom
feature/russell
Nov 17, 2025
Merged

Merge benchmarks by Russell and Yuxuan into Development#6
McLavish merged 29 commits into
developmentfrom
feature/russell

Conversation

@Russellpang
Copy link
Copy Markdown
Collaborator

No description provided.

@McLavish McLavish changed the title Feature/russell Draft: Feature/russell Nov 6, 2025
@McLavish McLavish changed the title Draft: Feature/russell Feature/russell Nov 6, 2025
@McLavish McLavish marked this pull request as draft November 6, 2025 10:25
@McLavish McLavish added this to the benchmark implementation 1 milestone Nov 6, 2025
xipang and others added 6 commits November 12, 2025 20:24
sync: image-classification requirements + add 605.lu benchmark

- Resolve conflicts in 413.image-classification/python/requirements*
- Drop py3.6/py3.7 variants removed upstream; keep/update 3.8–3.11
- Add new 600.linearalgebra/605.lu benchmark (config, input, function, reqs)
- Rename local_deployment.tmp -> 600.linearalgebra/605.lu/config.json
- Update local_deployment.json; add out_benchmark*.json; update out_storage.json
@McLavish McLavish marked this pull request as ready for review November 13, 2025 10:19
@McLavish
Copy link
Copy Markdown
Owner

Erm you have leaked your private shh key in this public PR... you might want to change it

@McLavish
Copy link
Copy Markdown
Owner

The benchmarks LGTM, just uncommit all the output files and the json configs, those are auto generated and shouldn't be added to the repo

Comment thread out_storage.json Outdated
Comment thread out_benchmark.json Outdated
Comment thread install.py
Comment thread eval "$(ssh-agent -s)".pub Outdated
Comment thread eval "$(ssh-agent -s)" Outdated
Comment thread config/local_deployment.json Outdated
@Russellpang Russellpang requested a review from McLavish November 17, 2025 17:22
@McLavish
Copy link
Copy Markdown
Owner

McLavish commented Nov 17, 2025

PR Merging checklist:

The person doing the PR

  • I have tested all the benchmarks and they run locally
  • I have deleted the cache folder and re-run the benchmarks
  • I have tested my benchmarks on another machine

For the reviewer:

  • I have checked the changed files
  • I have run the benchmarks on my machine

Copy link
Copy Markdown
Owner

@McLavish McLavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread config/local_deployment.json Outdated
@@ -0,0 +1 @@

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what

Comment thread install.py
@McLavish McLavish changed the title Feature/russell Merge benchmarks by Russell andYuxuanLiu into Development Nov 17, 2025
@McLavish McLavish changed the title Merge benchmarks by Russell andYuxuanLiu into Development Merge benchmarks by Russell and Yuxuan into Development Nov 17, 2025
@McLavish
Copy link
Copy Markdown
Owner

update: deleted microbenchmark. It will go in a different PR

@McLavish McLavish merged commit 074d4b7 into development Nov 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants