Handle pre-releases on all in an and group #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2025
Up to this point, all versions in an and group needed to have a prerelease to be checked with those correctly. This change enables just one item in an and group to have a pre-release and engage it for all items in that and group. This does not work across ORs. For example, `>= 1.2.3 < 2.0.0-beta || > 3` will evaluate prereleases in the group between 1.2.3 and 2.0.0-beta but will not look at prereleases when looking at `>3`. Signed-off-by: Matt Farina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to this point, all versions in an and group needed to have a prerelease to be checked with those correctly. This change enables just one item in an and group to have a pre-release and engage it for all items in that and group.
This does not work across ORs. For example,
>= 1.2.3 < 2.0.0-beta || > 3will evaluate prereleases in the group between 1.2.3 and 2.0.0-beta but will not look at prereleases when looking at>3.Closes #259