Restore detailed errors when failed to parse with NewVersion #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the NewVersion regex was updated to be more accurate, some of the returned errors were lost. Some projects (e.g., Helm) had tests for this and caught the different returned error. This change restores those errors by default but provides a package level opt-out that is more performant. Signed-off-by: Matt Farina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the NewVersion regex was updated to be more accurate, some of the returned errors were lost. Some projects (e.g., Helm) had tests for this and caught the different returned error. This change restores those errors by default but provides a package level opt-out that is more performant.