added auth dir in AuthCommand to move controllers to controllers/auth/#875
Merged
josephmancuso merged 9 commits intoMasoniteFramework:developfrom Sep 14, 2019
Merged
Conversation
|
Didn't receive a comment on this PR until now. Do I need to update anything? |
Member
|
A quick look shows that you also need to update this block too to point the controllers to the new subdirectory https://github.com/MasoniteFramework/core/blob/2.2/masonite/commands/AuthCommand.py#L21-L35 |
|
@josephmancuso Made the change in routers as well. |
|
Hey, awaiting review. |
Member
|
@vaibhavmule ☝️ can you review this? This will need a manual review at the moment |
Member
|
Since this is a directory change I'd like to move this into the develop branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.