Skip to content

A bit of cleanup and using self.*_named_attribute#3

Merged
MartinBaGar merged 1 commit intoMartinBaGar:mainfrom
BradyAJohnston:MartinBaGar/main
Feb 26, 2025
Merged

A bit of cleanup and using self.*_named_attribute#3
MartinBaGar merged 1 commit intoMartinBaGar:mainfrom
BradyAJohnston:MartinBaGar/main

Conversation

@BradyAJohnston
Copy link

I've gone through and done a bit of cleanup, but it was mostly how it it should be I think!

I'll leave individual comments on sections, but mostly what I have changed is moving to using self.store_named_attribute() as MolecularEntity already subclasses BlenderObject and thus gets those methods. I lead you a bit astray with my example in the original thread, but thanks for doing it all!

Cleans up and minimises code use. As the Interaction is a subclass of `MolecularEntity`, we can use the self.store_named_attribute() methods, and reference the object via self.object.
@BradyAJohnston
Copy link
Author

If you accept this PR it should then be reflected in the other PR. I wanted to do it this way so I could comment everything change-wise :)

@MartinBaGar MartinBaGar merged commit d014764 into MartinBaGar:main Feb 26, 2025
@MartinBaGar
Copy link
Owner

Thanks a lot for your reviews, I'm glad it is going in the right direction :)
No worries with the example, thanks to it I could dig into databpy and have a more in depth understanding of Molecular Nodes ecosystem, I hope I am not going to slow on this project.
If you have other suggestions of functionalities, let me know ! I will propose the next steps on the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants