A bit of cleanup and using self.*_named_attribute#3
Merged
MartinBaGar merged 1 commit intoMartinBaGar:mainfrom Feb 26, 2025
Merged
A bit of cleanup and using self.*_named_attribute#3MartinBaGar merged 1 commit intoMartinBaGar:mainfrom
MartinBaGar merged 1 commit intoMartinBaGar:mainfrom
Conversation
Cleans up and minimises code use. As the Interaction is a subclass of `MolecularEntity`, we can use the self.store_named_attribute() methods, and reference the object via self.object.
Author
|
If you accept this PR it should then be reflected in the other PR. I wanted to do it this way so I could comment everything change-wise :) |
Owner
|
Thanks a lot for your reviews, I'm glad it is going in the right direction :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've gone through and done a bit of cleanup, but it was mostly how it it should be I think!
I'll leave individual comments on sections, but mostly what I have changed is moving to using
self.store_named_attribute()asMolecularEntityalready subclassesBlenderObjectand thus gets those methods. I lead you a bit astray with my example in the original thread, but thanks for doing it all!