FTMotion: Fix K unit and Improve linear advance - #28058
Conversation
|
@dbuezas , don't forget to update the motion menu accordingly. I've tested your |
|
Thanks! |
|
I mean the maximum value and the display to be aligned with the new value. |
|
Got it, good catch. Maybe i even do more decimals |
|
Any chance of fixing the output from M493? |
|
Just realized i can reuse the use_advance_lead from the block |
|
@Crazy-Charles Yes, will be fixed in a different PR. It's ready for review & merge |
3bd3f1c to
1ffa8e9
Compare
607bb0e to
f78c928
Compare
503173f to
0014831
Compare
0014831 to
d5c1128
Compare
Description
FTMotion had K defined in a different unit (100 times that of the normal motion system, klipper, etc)
This PR aligns that, and also fixes problems during (de)retraction: these blocks shouldn't use linear advance.
Furthermore, I simplified the math by using the integral of the linear advance equation used in the classic motion planner, which has the advantage of not losing track of the integration constant between blocks due to instantaneous changes in velocity (i.e, linear advance is now jerk aware)
Equivalence of rate base and position based linear advance
Requirements
FTMotion
Benefits
Same unit, simpler code, no drift, better pressure management
Configurations
Related Issues