Skip to content

fix typo in TEMP_SENSOR_BED_USES_SW_SPI test#27938

Merged
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.1.xfrom
ellensp:fix-TEMP_SENSOR_BED_USES_SW_SPI
Jun 22, 2025
Merged

fix typo in TEMP_SENSOR_BED_USES_SW_SPI test#27938
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.1.xfrom
ellensp:fix-TEMP_SENSOR_BED_USES_SW_SPI

Conversation

@ellensp
Copy link
Contributor

@ellensp ellensp commented Jun 22, 2025 •
edited
Loading

Description

While taking a casual look at how MAX31865 is implemented for heated beds I noticed this bit of code.

#if TEMP_SENSOR_IS_ANY_MAX_TC(BED) && TEMP_SENSOR_0_HAS_SPI_PINS && DISABLED(TEMP_SENSOR_FORCE_HW_SPI)
  #define TEMP_SENSOR_BED_USES_SW_SPI 1
#endif

but this test should not be looking at TEMP_SENSOR_0_HAS_SPI_PINS but at TEMP_SENSOR_BED_HAS_SPI_PINS instead

Updated.

Requirements

#define TEMP_SENSOR_BED -5 // MAX31865

Benefits

TEMP_SENSOR_BED_USES_SW_SPI is set correctly

Configurations

Test Configuration.zip

Related Issues

  • [BUG] Support for bed MAX31865 on esp32 #27610
    •

    @ellensp ellensp added this to the Version 2.1.3 milestone Jun 22, 2025
    @thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 2 times, most recently from 55c15f9 to de219dc Compare June 22, 2025 17:38
    @thinkyhead thinkyhead merged commit 685ccf3 into MarlinFirmware:bugfix-2.1.x Jun 22, 2025
    66 checks passed
    @ellensp ellensp deleted the fix-TEMP_SENSOR_BED_USES_SW_SPI branch June 22, 2025 21:44
    @thisiskeithb thisiskeithb linked an issue Jun 23, 2025 that may be closed by this pull request
    [BUG] Support for bed MAX31865 on esp32 #27610
    Open
    Crazy-Charles pushed a commit to Crazy-Charles/Marlin that referenced this pull request Jun 28, 2025
    @ellensp @Crazy-Charles
    🔧 Fix TEMP_SENSOR_BED_USES_SW_SPI (MarlinFirmware#27938)
    c652c8b 
    Followup to MarlinFirmware#26441
    bsdnomad pushed a commit to bsdnomad/Marlin that referenced this pull request Sep 25, 2025
    @ellensp @bsdnomad
    🔧 Fix TEMP_SENSOR_BED_USES_SW_SPI (MarlinFirmware#27938)
    c50a12f 
    Followup to MarlinFirmware#26441
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    C: Temperatures PR: Bug Fix

    Projects

    None yet

    Milestone

    Version 2.1.3

    Development

    Successfully merging this pull request may close these issues.

    [BUG] Support for bed MAX31865 on esp32

    2 participants

    @ellensp @thinkyhead