move SPI_FLASH_BACKUP to Conditionals-5 again#27936
Merged
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.1.xfrom Jun 22, 2025
Merged
move SPI_FLASH_BACKUP to Conditionals-5 again#27936thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.1.xfrom
thinkyhead merged 3 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test for SPI_FLASH_BACKUP is in Marlin/src/inc/Conditionals-4-adv.h
#if ALL(SPI_FLASH, HAS_MEDIA, MARLIN_DEV_MODE)SPI_FLASH is set in the boards pins.h file
From Conditionals-4-adv.h
* Conditionals set before pins.h and which depend on Configuration_adv.h.This is accurate. defines in the pins files are not used here.
Moved the test to Marlin/src/inc/Conditionals-5-post.h again.
Requirements
A board that has SPI flash (such as BOARD_MKS_ROBIN_NANO_V3_1
MARLIN_DEV_MODE to add M993 aand M994
SDSUPPORT required for these gcodes
Benefits
SPI_FLASH_BACKUP is set as expected
Configurations
Configuration.zip
Related Issues