Follow up to "Fix ProUI LCD wake up (#27832)"#27835
Merged
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.1.xfrom May 6, 2025
Merged
Follow up to "Fix ProUI LCD wake up (#27832)"#27835thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.1.xfrom
thinkyhead merged 2 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 15, 2025
rommo911
pushed a commit
to rommo911/Marlin-e3v2
that referenced
this pull request
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a slight issue regarding this... the LCD should come back to full functionality whether the knob is turned or pressed in. Currently, this gives partially functionality; when the screen is off, turning the knob or pressing the button does bring the screen back on, and you can navigate freely (like normal) however, you have to press the knob in (again) in order to work like it did when the screen is on (fully functional).
This aims to make the LCD come back on with a turn of a knob (left or right), or pressing in the knob (enter), and being able to navigate the screen like normal as if the LCD was never off (so the user doesn't have to press the knob in again).
Note
However, while this may fix one thing, this causes another inconvenience, but this PR should also fix that.
So, when a print job is done, and say you print something, and the LCD timer turns the screen off and you come back when it is finished, Turning the knob or pressing in the button will exit the Print Finished screen right away and to the main menu.
By adding
if (checkkey != ID_PrintDone) wait_for_user = false;, this should solve that, but testing is needed.Requirements
ProUI - DWIN / Ender3-V2 LCD
Benefits
Configurations
Related Issues
seeNOTEabove. testing needed,