Edit CONFIGURABLE_MACHINE_NAME - M550#27772
Open
classicrocker883 wants to merge 29 commits intoMarlinFirmware:bugfix-2.1.xfrom
Open
Edit CONFIGURABLE_MACHINE_NAME - M550#27772classicrocker883 wants to merge 29 commits intoMarlinFirmware:bugfix-2.1.xfrom
classicrocker883 wants to merge 29 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
thinkyhead
force-pushed
the
bugfix-2.1.x-March7
branch
from
0806931 to
62639d4
Compare
thinkyhead
force-pushed
the
bugfix-2.1.x-March7
branch
from
34fb5e7 to
1a8fd8a
Compare
Member
|
Sorry for the current broken CI testing. I'm reviewing some old sanity checks that are either obsolete or just interesting. Testing each of these with different variations of M550 P"Quoted Parm1"
M550 P "Quoted Parm2"
M550 P "Unclosed Parm3\
M550 P"Name \"too\" incredibly long to store the whole entire lengthy appellation."
M550 PUnquoted Spaced
M550 P Unq.Spaced Two
M550 String Name P24
M550 "Quoted String"
M550 P3DPrinter |
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
3791e7d to
6ea4a16
Compare
Contributor
Author
|
So i've updated this gcode, and tested it with please see description of these changes. |
… into bugfix-2.1.x-March7
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
3 times, most recently
from
52532da to
06c6c47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #27731
CONFIGURABLE_MACHINE_NAMEM550.cpp
GCODE_QUOTED_STRINGSdisabled.When
GCODE_QUOTED_STRINGSis enabled, it is possible to rename with or without quotesM550 <name>M550 "<name>"Otherwise, when it is disabled, quotes will be passed on in the machine name.
Requirements
Benefits
More options with
M550Related Issues
Upon starting a printer, like Ender-3V2, the Welcome MSG usually says "
MACHINE_NAMEReady."or
"3D Printer Ready."
however, when it is defined as
"$", this becomes "$ Ready." on startingApparently according to settings.cpp the remedy is to reset. So after first flashing the firmware, that is the issue.