Skip to content

Adjust runout distance menu edit if FILAMENT_MOTION_SENSOR enabled. - #27540

Merged
thinkyhead merged 2 commits into
MarlinFirmware:bugfix-2.1.xfrom
vovodroid:runout_dist_pr
Nov 25, 2024
Merged

Adjust runout distance menu edit if FILAMENT_MOTION_SENSOR enabled.#27540
thinkyhead merged 2 commits into
MarlinFirmware:bugfix-2.1.xfrom
vovodroid:runout_dist_pr

Conversation

@vovodroid

Copy link
Copy Markdown
Contributor

When FILAMENT_MOTION_SENSOR is enabled increase runout edit precision to 0.1mm and reduce maximum to 10mm.

@robherc

robherc commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

Why would this be seen as an improvement? Most filament runout sensors will be much more than 10mm away from the extruder (extremely frequently more than 100mm), and whether you stop 0.1mm away from the absolute end of the filament, or 1.5mm, makes very little difference in "the grand scheme."

@vovodroid

vovodroid commented Nov 23, 2024

Copy link
Copy Markdown
Contributor Author

If you have filament motion sensor, you would like to stop printing ASAP.

@robherc

robherc commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

If you have filament motion sensor, you would like to stop printing ASAP.

In that case, you have no need for any distance measurement, because you're trying to "stop right now."

I think the intent of the runout distance is for those of us who would prefer to know the filament is running out while there's still time to prep the next spool before the printer runs out; but then have the printer auto-pause before it ruins the print, if we haven't manually changed it yet.

@vovodroid

vovodroid commented Nov 23, 2024 via email

Copy link
Copy Markdown
Contributor Author

@robherc

robherc commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

Ok, so if using a motion-detector, just set length to 1mm and be done, if that is your worry.
Or is there some other concern here?

@vovodroid

vovodroid commented Nov 24, 2024 via email

Copy link
Copy Markdown
Contributor Author

@robherc

robherc commented Nov 24, 2024

Copy link
Copy Markdown
Contributor

but you said you have no ability to use the precision (so no benefit), and by reducing the range you would completely destroy a very useful feature for everyone with microswitch runout sensors (so major detriment).

@vovodroid

vovodroid commented Nov 24, 2024 via email

Copy link
Copy Markdown
Contributor Author

@robherc

robherc commented Nov 24, 2024

Copy link
Copy Markdown
Contributor

Ok, the new change is fine for my purposes.
Idk how everyone else who uses motion sensors will respond, because I would expect some of them to prefer higher lengths too, but I can't speak for them necessarily.

@vovodroid

Copy link
Copy Markdown
Contributor Author

I would expect some of them to prefer higher lengths too

Currently I use 2.4mm. I started from 2.0, and increased it due to false detection.

@robherc

robherc commented Nov 24, 2024

Copy link
Copy Markdown
Contributor

Currently I use 2.4mm. I started from 2.0, and increased it due to false detection.
...so this length is being used as the amount of filament-travel between "clicks" on the fil. motion detector...seems like that should be an entirely different variable.

@vovodroid

Copy link
Copy Markdown
Contributor Author

this length is being used as the amount of filament-travel between "clicks" on the fil. motion detector

Exactly

seems like that should be an entirely different variable.

Yes, but it's another issue.

@thinkyhead
thinkyhead merged commit 8d864d7 into MarlinFirmware:bugfix-2.1.x Nov 25, 2024
@vovodroid
vovodroid deleted the runout_dist_pr branch November 25, 2024 08:06
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants