Skip to content

🔨 Simplify generic variants, update DFU tool - #27502

Merged
thinkyhead merged 3 commits into
MarlinFirmware:bugfix-2.1.xfrom
thinkyhead:bf2_build_updates_PR
Nov 2, 2024
Merged

🔨 Simplify generic variants, update DFU tool#27502
thinkyhead merged 3 commits into
MarlinFirmware:bugfix-2.1.xfrom
thinkyhead:bf2_build_updates_PR

Conversation

@thinkyhead

Copy link
Copy Markdown
Member
  • Update to DFU tool 1.11.0 with minor patches — for better macOS compatibility (eventually). See this thread.
  • Modify "variant" scripts to point the build.variants_dir at our folder (instead of copying into the platform).
  • Rename some boards and variants to match siblings.

@thinkyhead
thinkyhead force-pushed the bf2_build_updates_PR branch from 81767f0 to b4e480a Compare October 29, 2024 23:25
Comment thread buildroot/share/PlatformIO/scripts/STM32F1_create_variant.py
@thinkyhead

Copy link
Copy Markdown
Member Author

Double-checked to make sure files are indeed being included, and it all seems good. Maple can't take the same approach, but maybe it's possible to set extra environment vars or other build flags to sort out #include <...> lines within the Maple variants.

@thinkyhead
thinkyhead merged commit 08717d3 into MarlinFirmware:bugfix-2.1.x Nov 2, 2024
@thinkyhead
thinkyhead deleted the bf2_build_updates_PR branch November 2, 2024 23:42
@vehystrix

Copy link
Copy Markdown
Contributor

Since the change in generic_create_variant.py I get build errors. I get as far as this:

Linking .pio\build\MKS_E3_V2\firmware.elf
arm-none-eabi-g++: error: C:/Users/VEH/Documents/3DPrint/Printer: No such file or directory
arm-none-eabi-g++: error: upgrades/Marlin/buildroot/share/PlatformIO/variants/MARLIN_MKS_E3/ldscript.ld: No such file or directory
*** [.pio\build\MKS_E3_V2\firmware.elf] Error 1

Note that I am using the path C:\Users\VEH\Documents\3DPrint\Printer upgrades\Marlin as my marlin source path. When I remove the space in the path, the build completes as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants