🔧 Enable EDGE_STEPPING by default with TMC drivers

[thisiskeithb]

Description

Enable EDGE_STEPPING by default. This was originally planned to be enabled by default after a test period back in 2019, but never happened (source).

This is something I enable on my builds and haven't run into any issues. It's been around long enough that I think it should be enabled by default.

Requirements

Any TMC-based config.

Benefits

Better defaults for TMC-based configs.

Configurations

Any TMC-based config.

[ellensp]

I disagree with doing this, default is for 'lowest' spec everything. ie in this case A4988's which do not support edge stepping.

[thisiskeithb]

I disagree with doing this, default is for 'lowest' spec everything. ie in this case A4988's which do not support edge stepping.

Good thing this feature is guarded by HAS_TRINAMIC_CONFIG.

[thinkyhead]

Good thing this feature is guarded by HAS_TRINAMIC_CONFIG

Options enabled in the configs should reflect the real configuration as closely as possible, regardless of how the conditionals might adjust them, especially for "add-on" features. So if there are no Trinamic drivers, this should be disabled.

I do think it makes sense to throw a #warning, or even an #error when users forget to set this option in the presence of Trinamic steppers, but still allow the option to be disabled for development and testing purposes.

[thinkyhead]

Anyway, the default of EDGE_STEPPING enabled does make sense for this case since it's inside the guards.

[thisiskeithb]

So if there are no Trinamic drivers, this should be disabled.

That's exactly what happens when there are no (smart) Trinamic drivers enabled since HAS_TRINAMIC_CONFIG will be false.

[ellensp]

How many example configs need updating as they now fail to build with this new #error? Needs checking...
We can already see it breaks CI tests that didn't enable EDGE_STEPPING (or the override) as now needed

[ellensp]

My initial reluctance was due to missing that EGDE_STEPPING is in a #if HAS_TRINAMIC_CONFIG block.
I no longer have any concerns other than needing to update CI tests and example configs before this is merged.

[ellensp]

I do wonder if "we" should just go one step further.

Remove edge stepping option entirely from the the Configs and just replace it in code with HAS_TRINAMIC_CONFIG tests

Ie why would you ever want or need to disable it?

[thisiskeithb]

Remove edge stepping option entirely from the the Configs and just replace it in code with HAS_TRINAMIC_CONFIG tests

I'd be fine with that as well. Just hold changes until after 2.1.3 in case there's some unexpected issue that we've yet to run into.

[thinkyhead]

I think it's important to keep the option because it's a feature of the steppers drivers and it's nice to keep it exposed.