NUM_ENDSTOP_STATES incorrect when Z_MIN_PROBE = Z_MIN

[tombrazier]

Description

When Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN is defined, NUM_ENDSTOP_STATES can end up being incorrect. This is because NUM_ENDSTOP_STATES is assigned the value Z_MIN_PROBE + 1 by the compiler and, in this particular case, Z_MIN_PROBE is an alias for Z_MIN.

An example case is when Z_HOME_DIR == 1, in which case the following asserts should work:

static_assert(X_MIN == 0);
static_assert(Y_MIN == 1);
static_assert(Z_MIN == 2);
static_assert(Z_MAX == 3);
static_assert(NUM_ENDSTOP_STATES == 4);
static_assert(X_ENDSTOP == X_MIN);
static_assert(Y_ENDSTOP == Y_MIN);
static_assert(Z_ENDSTOP == Z_MAX);
static_assert(Z_MIN_PROBE == Z_MIN);

However in this case NUM_ENDSTOP_STATES ends up being Z_MIN_PROBE + 1 == Z_MIN + 1 == 3.

Requirements

N/A

Benefits

This fixes an edge case where endstop_mask_t has an underlying type which is too narrow.

Configurations

configs.zip

Related Issues