Sanity Check TMC_HOME_PHASE and CORE / MARKFORGED Kinematics - #26310
Merged
Conversation
Core machines can't reliably settle on the same phase for homing core axes. For instance, with CoreXY, X and Y positions depend on both A and B motors, so the homing A phase depends on exact location of X and Y (== on the position of B motor). Fixes MarlinFirmware#26307
thisiskeithb
changed the title
Contributor
Author
|
Can this be merged? |
Member
No worries. Everything in the queue will be reviewed and merged before the next release. |
thinkyhead
force-pushed
the
tmc_home_sanity
branch
from
October 7, 2023 00:42
f0b42eb to
a02b8e8
Compare
thinkyhead
force-pushed
the
tmc_home_sanity
branch
from
October 7, 2023 00:51
a02b8e8 to
ade0bd8
Compare
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
Oct 26, 2023
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Core machines can't reliably settle on the same phase for homing core axes. For instance, with CoreXY, X and Y positions depend on both A and B motors, so the homing A phase depends on exact location of X and Y (== on the position of B motor).
Fixes #26307
Benefits
The more sanity checks the better.