Skip to content

✨ Migration-specific tool change settings#26244

Merged
thinkyhead merged 10 commits intoMarlinFirmware:bugfix-2.1.xfrom
studiodyne:migration_custom
Oct 20, 2023
Merged

✨ Migration-specific tool change settings#26244
thinkyhead merged 10 commits intoMarlinFirmware:bugfix-2.1.xfrom
studiodyne:migration_custom

Conversation

@studiodyne
Copy link
Contributor

@studiodyne studiodyne commented Sep 5, 2023

Add custom settings for MIGRATION

Why? : Migration use common settings of 'toolchange', and it's not serious. Migration is a priming sequence, that must be in a special area, and in any starting gcode M217 settings are made for prime tower and toolchange short process inside bed. Inside a bed , a tool change will not park/prime/cool/cut/return :Now Migration have separated settings , to avoid this bad situation.
Thks

thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Oct 19, 2023
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Oct 19, 2023
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Oct 19, 2023
@thinkyhead thinkyhead changed the title [FIX] Migration_settings ✨ Migration-specific tool change settings Oct 19, 2023
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Oct 20, 2023
@thinkyhead thinkyhead merged commit 4b0b00c into MarlinFirmware:bugfix-2.1.x Oct 20, 2023
Pragma8123 pushed a commit to Pragma8123/Bender that referenced this pull request Oct 24, 2023
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request Oct 26, 2023
@studiodyne
Copy link
Contributor Author

@thinkyhead
Restoration of tmp_mig_settings is forgotten (immediatly after toolchange)

@thisiskeithb
Copy link
Member

@thinkyhead Restoration of tmp_mig_settings is forgotten (immediatly after toolchange)

Since this PR is merged/closed, you'll need to open a new one (or create a bug report if you're not able to).

@thinkyhead
Copy link
Member

Restoration of tmp_mig_settings is forgotten (immediatly after toolchange)

Open a debugger and check that. The REMEMBER macro creates an object that does RESTORE when it goes out of scope, so no explicit restore is required unless restoration is needed before exit.

@studiodyne studiodyne deleted the migration_custom branch December 2, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants