Restore use of Z_CLEARANCE_MULTI_PROBE to adjust probe error margin#26229
Merged
thinkyhead merged 14 commits intoMarlinFirmware:bugfix-2.1.xfrom Oct 15, 2023
Merged
Conversation
- Fix regression introduced by c599c93 on TAZ printers
thinkyhead
force-pushed
the
pr-lulzbot-probe-regression-sept-4
branch
from
de57b7e to
a58eae2
Compare
Member
|
Since it seems useful to tune the safety margin for certain leveling situations I went ahead and exposed the option as |
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Oct 12, 2023
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Oct 12, 2023
mikezs
added a commit
to mikezs/Marlin
that referenced
this pull request
Oct 17, 2023
* bugfix-2.1.x: (51 commits) [cron] Bump distribution date (2023-10-15) ✨ Z_PROBE_ERROR_TOLERANCE (expose) (MarlinFirmware#26229) [cron] Bump distribution date (2023-10-13) 🧑💻 IA Creality optional code [cron] Bump distribution date (2023-10-12) 🔧 Misc. probe opts 📝 GCode => G-Code 🧑💻 FxdTiCtrl => FTMotion redux 🚸 Update FTDI Eve / CocoaPress UI (MarlinFirmware#26233) 🧑💻 FxdTiCtrl => FTMotion 📝 Macro comments [cron] Bump distribution date (2023-10-11) ✨ Nonlinear Extrusion Control (M592) (MarlinFirmware#26127) [cron] Bump distribution date (2023-10-10) 🐛 Fix tool-change E prime (MarlinFirmware#26237) ✨ FYSETC Cheetah v3.0 (MarlinFirmware#26314) 🔧 BTT_MINI_12864_V1 => BTT_MINI_12864 (MarlinFirmware#26160) 🔧 More angles for 2x Servo Switching Nozzle (MarlinFirmware#26303) [cron] Bump distribution date (2023-10-09) 🩹 Patches for MSC SD (MarlinFirmware#26332) ... # Conflicts: # .github/workflows/test-builds.yml
Pragma8123
pushed a commit
to Pragma8123/Bender
that referenced
this pull request
Oct 24, 2023
Co-authored-by: Scott Lahteine <[email protected]>
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
Oct 26, 2023
Co-authored-by: Scott Lahteine <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It looks like in commit c599c93, Z_CLEARANCE_MULTI_PROBE was replaced with a hard-coded value of 2.0f. This was causing problems on certain Lulzbot TAZ printers which set Z_CLEARANCE_MULTI_PROBE to 5.
This PR restores the prior behavior by initializing error_tolerance to Z_CLEARANCE_MULTI_PROBE