DISTINCT_E_FACTORS compile error with input shaping - #26167
Merged
thinkyhead merged 2 commits intoOct 27, 2023
Conversation
…EPS_PER_UNIT and DEFAULT_MAX_FEEDRATE may have to be repeated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
DISTINCT_E_FACTORSis used, the comment inConfiguration.hsaysThe logic for calculating input shaping buffer size does not take this into account and this can cause a compile time error.
This PR essentially copies the following logic from settings.cpp into the input shaping buffer size calculation logic.
Marlin/Marlin/src/module/settings.cpp
Lines 1858 to 1860 in 2bac783
Requirements
Enable
DISTINCT_E_FACTORSand do not specify values for all extruders inDEFAULT_AXIS_STEPS_PER_UNITorDEFAULT_MAX_FEEDRATE.Benefits
The code compiles.
Configurations
See above.
Related Issues
This conversation on 3D Printing Discord server