Various LCD / backlight adjustments#26086
Various LCD / backlight adjustments#26086thinkyhead merged 54 commits intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
fix previously commented
… into bugfix-2.1.x-fix
… into bugfix-2.1.x-fix
… into bugfix-2.1.x-fix
… into bugfix-2.1.x-fix
… into bugfix-2.1.x-fix
… into bugfix-2.1.x-fix
4d32af0 to
b565d41
Compare
Keep in mind that we cannot use |
b565d41 to
429ae63
Compare
1500f9a to
6bc3df7
Compare
34f571c to
5e0c0a1
Compare
|
|
everything you changed is looking good. however a couple things needed to addressed, I did the necessary tweaks. had to omit and revert back the range for JyersUI/dwin.cpp line ~400. if say you went ahead and used in this part of the function // Draw value square grid
GRID_LOOP(x, y) {I know this because I tested it that way, having |
|
I went ahead and cleaned up the
|
7203759 to
fcad869
Compare
fcad869 to
74c7f3a
Compare
thanks for taking the time and doing that, its looking good, ill give it a test shot. quick question regarding the G-code preview feature, when selecting to view a file with a thumbnail more than once, following these steps:
depending on the file, you can do this twice or sometimes 3 or 4 times until it freezes/crashes and reboots. so obviously somewhere in memory where the image is stored it overloads, there should be a way to clear the cache or address when selecting Cancel instead of print. I've tried a few different things that haven't worked like more about it here. #26169 while we are on the subject is there anything which may alleviate the situation? |
|
just wanted to comment saying I updated the plot.cpp plot.h and made |
I found one possible culprit. The If this doesn't fix the problem then we should look further. |
|
Good PR! @classicrocker883 thanks for your contributions, feel free to port the features that you consider helpful from my fork to Marlin, I think that this will help me henceforth to fully focus in my fork. |
* bugfix-2.1.x: (25 commits) [cron] Bump distribution date (2023-08-26) ✨ Mellow Fly E3 V2 (STM32F407VG) (MarlinFirmware#26081) 🚸 Fixes for ProUI, JyersUI, backlight, etc. (MarlinFirmware#26086) 🧑💻 Encapsulate ProUI G-code preview [cron] Bump distribution date (2023-08-25) 🧑💻 Adjust LCD string draw (MarlinFirmware#26154) [cron] Bump distribution date (2023-08-24) 📝 Thermistor info updates (MarlinFirmware#26202) [cron] Bump distribution date (2023-08-23) ✨ G-code 'T' report current tool (MarlinFirmware#26151) 🔧 Allow arbitrary BLOCK_BUFFER_SIZE 🔧 Fix Linear Leveling grid size sanity check (MarlinFirmware#26199) 🚸 Avoid LCD messages starting with "Error:" (MarlinFirmware#26164) 🩹 Fix FT Motion menu Back item (MarlinFirmware#26175) [cron] Bump distribution date (2023-08-22) ✅ Fix unused test 🐛 Fixes for G2/G3 arcs (MarlinFirmware#26170) [cron] Bump distribution date (2023-08-21) 🎨 FTDI cleanup [cron] Bump distribution date (2023-08-20) ...
Co-authored-by: Scott Lahteine <[email protected]>
Co-authored-by: Scott Lahteine <[email protected]>
Description
the range did not allocate difference between Max and Min (+/-) and used just one value for both +/-
also added
+to make difference of +/-LCD_BACKLIGHT_TIMEOUT_MINSadded support for DWIN type displays for LCD timeout (in mins).
LCD display and timeout and turn off after a certain amount of time has passed - screen saver-esque.
in meshviewer, when it draws circles to indicate high or low spots on the bed, the circle colors have a more linear gradient - which is more true to how it should look, corresponding to values. also values aren't limited to 0.20. (fixed that).
in the more recent commit for ProUI,
ADVANCE_PAUSE_FEATURE"#if" statements were rearrange / ommited so that the adv pause feature can be disabled yet still utilize the other menu pages / functions.Updated CMakeLists.txt to stow warning for depreciated versions. Also added a "In case of..." / To Do If... comment.
in WindowsPaths.cmake or UnixPaths.cmake in the CMake install directory, an error may appear saying unknown command
_cmake_record_install_prefix(). I give a fix which simply has the user either comment out (#) that line, or addinclude(CMakeSystemSpecificInformation)above it which links to the file in which that function is defined.Renamed PlotClass. Updated to fix spelling typo (grph => graph). Changed how graph is updated, in the graph each "block" amounts to (60/2) - 30 seconds of time rather than (50/2) - 25 seconds.
Updated proui/dwin.cpp Variable update interval, from 1024 to 1000 (ms) and 500 (ms). which updates the menu a bit faster, temp - fan speed - blink - plot graph...
Requirements
Benefits
-stated in description-
for context, this is what the fix looks like
as you can see, the high and low values are correct. -0.24.....0.22+ otherwise originally it would read -0.24.....0.24+
This also adds the ability to set a timeout for the LCD (PROUI), could be implemented in JyersUI and Creality_LCD.
***For
SanityCheck, it was edited to quiet errors, not sure if these changes are the best but it should be reviewed.The fix to
dwinui.cppforRainbowInt-- better readability/implement code, draws the color gradient with wider spectrum (more true to color >> value)* .The fix to
meshviewer.cppallows it to draw the actual true value, instead it was limited to |0.20| on the View Mesh.also fixed latest ProUI commit, rearrange ADVANCE_PAUSE_FEATURE functions so when it is disabled other functions like
parkHeadcan be accessed.most recent plot.cpp plot.h fixes typo, 30sec graph plot between white bars instead of 25sec.
remove redundant
DWIN_UPDATE_INTERVAL/DWIN_VAR_UPDATE_INTERVAL, seperate the defined values to make better use. splitDWIN_VAR_UPDATE_INTERVALto update display variables in half time (faster).Configurations
#define LCD_BACKLIGHT_TIMEOUT_MINScan be uncommented - value of10for 10 minutes.Related Issues
possible
SanityCheckerror compatibility with other configurations.