Skip to content

Show mm'ss during first hour #23335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thinkyhead merged 3 commits into from
Dec 23, 2021
Merged

Show mm'ss during first hour #23335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd5a717
PRINTJOB_TIME shows mm:ss about the duration of a print during the fi…
UMO-printing Dec 22, 2021
5c78411
replace tabs, other adjustments
thinkyhead Dec 23, 2021
10e105f
minute symbol hint
thinkyhead Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions Marlin/src/libs/duration_t.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,11 @@ struct duration_t {
* 59s
*/
char* toString(char * const buffer) const {
int y = this->year(),
d = this->day() % 365,
h = this->hour() % 24,
m = this->minute() % 60,
s = this->second() % 60;
const uint16_t y = this->year(),
d = this->day() % 365,
h = this->hour() % 24,
m = this->minute() % 60,
s = this->second() % 60;

if (y) sprintf_P(buffer, PSTR("%iy %id %ih %im %is"), y, d, h, m, s);
else if (d) sprintf_P(buffer, PSTR("%id %ih %im %is"), d, h, m, s);
Expand All @@ -149,23 +149,29 @@ struct duration_t {
*
* Output examples:
* 123456789 (strlen)
* 12'34
* 99:59
* 11d 12:33
*/
uint8_t toDigital(char *buffer, bool with_days=false) const {
uint16_t h = uint16_t(this->hour()),
m = uint16_t(this->minute() % 60UL);
const uint16_t h = uint16_t(this->hour()),
m = uint16_t(this->minute() % 60UL);
if (with_days) {
uint16_t d = this->day();
sprintf_P(buffer, PSTR("%hud %02hu:%02hu"), d, h % 24, m);
const uint16_t d = this->day();
sprintf_P(buffer, PSTR("%hud %02hu:%02hu"), d, h % 24, m); // 1d 23:45
return d >= 10 ? 9 : 8;
}
else if (!h) {
const uint16_t s = uint16_t(this->second() % 60UL);
sprintf_P(buffer, PSTR("%02hu'%02hu"), m, s); // 12'34
return 5;
}
else if (h < 100) {
sprintf_P(buffer, PSTR("%02hu:%02hu"), h, m);
sprintf_P(buffer, PSTR("%02hu:%02hu"), h, m); // 12:34
return 5;
}
else {
sprintf_P(buffer, PSTR("%hu:%02hu"), h, m);
sprintf_P(buffer, PSTR("%hu:%02hu"), h, m); // 123:45
return 6;
}
}
Expand Down