Fix for PARKING_EXTRUDER homing and solenoid control by zeleps · Pull Request #20473 · MarlinFirmware/Marlin

zeleps · 2020-12-15T09:43:54Z

Description

PARKING_EXTRUDER feature is -apparently- not widely used and it appears that, through the many changes in the homing operation, the feature broke. As it is evident from the code remnants, the intention was to finish homing with the correct extruder unparked. This does not happen, and also there never was a provision for supporting an X_MAX homing configuration. Also, M380/381 gcodes did not take PARKING_EXTRUDER solenoid configuration into account, thus working in reverse under certain conditions. The proposed solution minimizes the movements necessary to unpark the right extruder after homing, while considering if the homing operation begins with no extruder attached and respecting the differences in homing direction.

Benefits

PARKING_EXTRUDER homing and solenoid control now work as initially intended

Configurations

Only PARKING_EXTRUDER needs to be enabled

Related Issues

None, it seems that this feature is not widely used, but it was broken nonetheless, so a fix was needed.

Integration Testing

Enable and configure PARING_EXTRUDER option.
Perform the following actions and verify results:

G28: Carriage homes X towards E0 (active) and grabs it, then completes Z-homing.
G28: Carriage homes with E0 attached
T1: Carriage parks E0, grabs E1
G28: Carriage homes with E1 attached
M381: Carriage releases E1 (E1 should be parked manually)
T1: Carriage directly grabs E1
M381: Carriage releases E1 (E1 should be parked manually)
T0: Carriage directly grabs E0
T1: Carriage parks E0, grabs E1
M381: Carriage releases E1 (E1 should be parked manually)
G28: Carriage homes X towards E0, completes Z homing and then grabs E1 directly

Reverse X-Axis homing (can be temporarily done in-place by reversing solenoid pins, endstop pins, USE_XMAX_PLUG, X_HOME_DIR and INVERT_X_DIR)
Perform the following actions and verify results:

G28: Carriage homes X towards E1, completes Z-homing, then grabs E0
G28: Carriage homes with E0 attached
T1: Carriage parks E0, grabs E1
G28: Carriage homes with E1 attached
M381: Carriage releases E1 (E1 should be parked manually)
T1: Carriage directly grabs E1
M381: Carriage releases E1 (E1 should be parked manually)
T0: Carriage directly grabs E0
T1: Carriage parks E0, grabs E1
M381: Carriage releases E1 (E1 should be parked manually)
G28: Carriage homes X towards E1 and grabs it, completes Z homing with E1 attached

thinkyhead · 2020-12-17T12:20:28Z

Thanks for taking the time to work out the issues. It's not always easy to find testers for these interesting features.

zeleps · 2020-12-17T12:28:10Z

Cheers @thinkyhead, your appraisal means a lot! I've been using Marlin for a couple of years now, this is the first time I took the initiative to contribute, mainly due to building a new printer from the scratch as a past-time project (now with the lockdown and all). I'll try to do it more in the future. Keep up the good work!

Marlin/src/feature/solenoid.cpp

thinkyhead · 2021-01-01T20:54:10Z

Thanks for the patch! Just had to do some final cleanup, and will merge shortly….

* [cron] Bump distribution date (2020-12-31) * SPI and pins cleanup * [cron] Bump distribution date (2021-01-01) * Prefix SD SPI pins (SCK, MISO, MOSI, SS) (MarlinFirmware#20606) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Fix PARKING_EXTRUDER homing with solenoid (MarlinFirmware#20473) * Fix CHAMBER_FAN_MODE 0 build (MarlinFirmware#20621) * [cron] Bump distribution date (2021-01-02) * Fix UBL mesh edit delta moves (MarlinFirmware#20620) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Fix //action prefix (MarlinFirmware#20600) * Assisted Tramming improvements (MarlinFirmware#20298) * Check for misplaced configs on build (MarlinFirmware#20599) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Fix a comment (MarlinFirmware#20629) * Document, adjust some homing code * Improved bootscreen animation * [cron] Bump distribution date (2021-01-03) * Homing code followup (MarlinFirmware#20632) Patching a87e519 * Animated boot followup * Add ALL_AXES manual move for UBL mesh editing Co-Authored-By: Jason Smith <20053467+sjasonsmith@users.noreply.github.com> MarlinFirmware#20620 * Creality 4.2.10 board (MarlinFirmware#20647) * Update Italian language (MarlinFirmware#20663) * [cron] Bump distribution date (2021-01-04) * Fix thermal error protection, reporting (MarlinFirmware#20655) * Rename FTDI EVE screen data structs * Fix SD SPI Speed override, FTDI mesh edit (MarlinFirmware#20657) Co-authored-by: Scott Lahteine <github@thinkyhead.com> * Fix IDEX reboot on travel after G28 X (MarlinFirmware#20654) * Fix delayed_move_time elapsed test * Move duplication_e_mask Co-authored-by: thinkyhead <thinkyhead@users.noreply.github.com> Co-authored-by: Scott Lahteine <github@thinkyhead.com> Co-authored-by: Victor Oliveira <rhapsodyv@gmail.com> Co-authored-by: zeleps <39417467+zeleps@users.noreply.github.com> Co-authored-by: Jason Smith <jason.inet@gmail.com> Co-authored-by: ellensp <ellensp@hotmail.com> Co-authored-by: qwewer0 <57561110+qwewer0@users.noreply.github.com> Co-authored-by: Giuliano Zaro <3684609+GMagician@users.noreply.github.com> Co-authored-by: Marcio T <mlt4356-github@yahoo.com> Co-authored-by: InsanityAutomation <38436470+InsanityAutomation@users.noreply.github.com>

Followups to #20473 ahead of #20675

Followups to MarlinFirmware#20473 ahead of MarlinFirmware#20675

Followups to #20473 ahead of #20675

zeleps added 2 commits December 15, 2020 09:31

Fixed broken PARKING_EXTRUDER operation.

9436a2e

Fixed configuration files

4be09f4

thisiskeithb added the F: Calibration label Dec 16, 2020

thinkyhead added 2 commits December 17, 2020 06:21

Merge remote-tracking branch 'upstream/bugfix-2.0.x' into pr/20473

8fde4f7

Update solenoid.cpp

444a9c0

zeleps commented Dec 17, 2020

View reviewed changes

Marlin/src/feature/solenoid.cpp Show resolved Hide resolved

thinkyhead added 6 commits December 17, 2020 06:37

Update T.cpp

1f39bc0

Update tool_change.cpp

e2fbd37

Update tool_change.cpp

1acc4a8

Update tool_change.cpp

c125727

invert

1f5826d

last touch

836cc1f

thinkyhead added the PR: Bug Fix label Jan 1, 2021

thinkyhead merged commit 815c636 into MarlinFirmware:bugfix-2.0.x Jan 1, 2021

zeleps mentioned this pull request Jan 4, 2021

Don't apply hotend_offset.z to Z soft endstops #20675

Merged

thinkyhead added a commit that referenced this pull request Jan 5, 2021

Solenoid cleanups

3a99d00

Followups to #20473 ahead of #20675

tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021

Fix PARKING_EXTRUDER homing with solenoid (MarlinFirmware#20473)

88fc2c9

tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021

Solenoid cleanups

85232bb

Followups to MarlinFirmware#20473 ahead of MarlinFirmware#20675

dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021

Fix PARKING_EXTRUDER homing with solenoid (MarlinFirmware#20473)

5192725

dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021

Solenoid cleanups

26d6114

Followups to MarlinFirmware#20473 ahead of MarlinFirmware#20675

kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021

Fix PARKING_EXTRUDER homing with solenoid (MarlinFirmware#20473)

0d52aa1

kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021

Solenoid cleanups

7a390a5

Followups to MarlinFirmware#20473 ahead of MarlinFirmware#20675

zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021

Fix PARKING_EXTRUDER homing with solenoid (MarlinFirmware#20473)

4d1485a

zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021

Solenoid cleanups

5b8754b

Followups to MarlinFirmware#20473 ahead of MarlinFirmware#20675

W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021

Fix PARKING_EXTRUDER homing with solenoid (MarlinFirmware#20473)

0cb7606

W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021

Solenoid cleanups

55554ee

Followups to MarlinFirmware#20473 ahead of MarlinFirmware#20675

thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021

Fix PARKING_EXTRUDER homing with solenoid (MarlinFirmware#20473)

1060f77

thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021

Solenoid cleanups

4982722

Followups to MarlinFirmware#20473 ahead of MarlinFirmware#20675

thinkyhead pushed a commit that referenced this pull request Apr 30, 2021

Fix PARKING_EXTRUDER homing with solenoid (#20473)

3b4c5f9

thinkyhead added a commit that referenced this pull request Apr 30, 2021

Solenoid cleanups

efe2859

Followups to #20473 ahead of #20675

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix for PARKING_EXTRUDER homing and solenoid control#20473

Fix for PARKING_EXTRUDER homing and solenoid control#20473
thinkyhead merged 10 commits intoMarlinFirmware:bugfix-2.0.xfrom
zeleps:bugfix-2.0.x-ParkingExtruderFix

zeleps commented Dec 15, 2020 •

edited

Loading

Uh oh!

thinkyhead commented Dec 17, 2020

Uh oh!

zeleps commented Dec 17, 2020

Uh oh!

Uh oh!

thinkyhead commented Jan 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

zeleps commented Dec 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Benefits

Configurations

Related Issues

Integration Testing

Uh oh!

thinkyhead commented Dec 17, 2020

Uh oh!

zeleps commented Dec 17, 2020

Uh oh!

Uh oh!

thinkyhead commented Jan 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zeleps commented Dec 15, 2020 •

edited

Loading