Disable UTF_FILENAME_SUPPORT by default#20135
Merged
thinkyhead merged 5 commits intoMarlinFirmware:bugfix-2.0.xfrom Nov 14, 2020
Merged
Disable UTF_FILENAME_SUPPORT by default#20135thinkyhead merged 5 commits intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 5 commits intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
Member
Author
|
Would a sanity check be preferred here instead? |
thinkyhead
force-pushed
the
bugfix-2.0.x
branch
from
4274255 to
a97a1ae
Compare
FhlostonParadise
pushed a commit
to FhlostonParadise/Marlin
that referenced
this pull request
Nov 21, 2020
Kannix2005
pushed a commit
to Kannix2005/Marlin-1
that referenced
this pull request
Dec 7, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
UTF_FILENAME_SUPPORTenabled by default, it causes issues with LCD controllers that don't support UTF-8 (Non-character controllers likeREPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER,CR10_STOCKDISPLAY, etc.)I noticed the issue when a hidden macOS folder was partially displayed on the LCD & not my "printed" folder which I toss printed g-code into once they're done:
UTF_FILENAME_SUPPORTenabledUTF_FILENAME_SUPPORTdisabledBenefits
Opt-in
UTF_FILENAME_SUPPORTvs. opt-out for configs.Related Issues
Issue #20114 and PRs #20087, #20121, #20115