Configure TMC interpolation per driver.#19828
Merged
thinkyhead merged 6 commits intoMarlinFirmware:bugfix-2.0.xfrom Oct 22, 2020
Merged
Configure TMC interpolation per driver.#19828thinkyhead merged 6 commits intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead merged 6 commits intoMarlinFirmware:bugfix-2.0.xfrom
Conversation
Contributor
|
You have the same “Use interpolation on X axis” comment for every axis. |
Contributor
Author
Thanks for catching that! |
teemuatlut
reviewed
Oct 21, 2020
teemuatlut
reviewed
Oct 21, 2020
Contributor
Author
|
@thinkyhead took care of the changes, and with using |
Speaka
pushed a commit
to Speaka/Marlin
that referenced
this pull request
Nov 2, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
chrisjenda
pushed a commit
to chrisjenda/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 28, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow enabling/disabling TMC driver interpolation on a per-driver basis.
Benefits
Allows using interpolation on some drivers (such as X/Y) while disabling it on others (probably most useful for E).
Configurations
Configuration.zip
I have tested this with TMC 2209 drivers on a Re-ARM. It would be a good idea to have tests done on other TMC drivers before this is merged.