[BUG] DWIN_CREALITY_LCD breaks MultiSerial

[blazewicz]

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

Compilation with multiple serial ports while having DWIN_CREALITY_LCD enabled results in a cascade of errors similar to this one:

Marlin/src/HAL/STM32F1/../../inc/../HAL/./STM32F1/../../core/serial_hook.h:225:68: error: request for member 'write' in '((MultiSerial<BaseSerial<MarlinSerial>, int, 0>*)this)->MultiSerial<BaseSerial<MarlinSerial>, int, 0>::serial1', which is of non-class type 'int'

It happens because SERIAL_CATCHALL is set here to an integer:

Marlin/Marlin/src/inc/Conditionals_LCD.h

Line 1079 in de38cae

#define SERIAL_CATCHALL 0

And here it is expected to be a compatible Serial class instance:

Marlin/Marlin/src/core/serial.h

Line 93 in de38cae

#define _SERIAL_LEAF_2 SERIAL_CATCHALL

I guess a simple fix like one below would help (it does compile).

--- a/Marlin/src/core/serial.h
+++ b/Marlin/src/core/serial.h
@@ -90,7 +90,7 @@ extern uint8_t marlin_debug_flags;
   #define SERIAL_ASSERT(P)    if(multiSerial.portMask!=(P)){ debugger(); }
   // If we have a catchall, use that directly
   #ifdef SERIAL_CATCHALL
-    #define _SERIAL_LEAF_2 SERIAL_CATCHALL
+    #define _SERIAL_LEAF_2 MSERIAL(SERIAL_CATCHALL)
   #elif HAS_ETHERNET
     typedef ConditionalSerial<decltype(MYSERIAL2)> SerialLeafT2;  // We need to create an instance here
     extern SerialLeafT2 msSerial2

Yet I'm not sure of the function on SERIAL_CATCHALL and how it should be defined properly.

@thinkyhead it seems you added it in #17719, I can't find any other reference nor documentation.

I think it got broken in #21306, but I'm not sure if it worked before.

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

bugfix-2.0.x

Printer model

No response

Electronics

No response

Add-ons

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

No response

[ellensp]

Please attach your configuration files.

[blazewicz]

Any configuration with DWIN LCD and MultiSerial fails. It can be easily reproduced using Configurations/config/examples/Creality/Ender-3 V2 with SERIAL_PORT_2 enabled:

--- a/Marlin/Configuration.h
+++ b/Marlin/Configuration.h
@@ -123,7 +125,7 @@
  * Currently Ethernet (-2) is only supported on Teensy 4.1 boards.
  * :[-2, -1, 0, 1, 2, 3, 4, 5, 6, 7]
  */
-//#define SERIAL_PORT_2 -1
+#define SERIAL_PORT_2 2

[ellensp]

Yes I can reproduce the original error.. But your diff to fix it, I cant replicate a compile at all.

[blazewicz]

With STM32F103RET6_creality env it fails because it can't find MSerial0 symbol, probably because Serial port 0 is not defined for this platform and SERIAL_CATCHAL is declared to be 0.

Marlin/src/HAL/STM32/../../inc/../HAL/./STM32/HAL.h:50:21: error: 'MSerial0' was not declared in this scope; did you mean 'MSerial10'?

It would compile if you changed:

--- a/Marlin/src/inc/Conditionals_LCD.h
+++ b/Marlin/src/inc/Conditionals_LCD.h
@@ -1076,7 +1076,7 @@
 #endif

 #if ENABLED(DWIN_CREALITY_LCD)
-  #define SERIAL_CATCHALL 0
+  #define SERIAL_CATCHALL 2
   #ifndef LCD_SERIAL_PORT
     #define LCD_SERIAL_PORT 3 // Creality 4.x board
   #endif

It is defined for STM32F103RET6_creality_maple's platform, but I don't know which port it represents.

I would suggest a fix, but I don't know what SERIAL_CATCHALL is.

[ellensp]

Bump... with people using the DWIN_CREALITY_LCD on more and more hardware, this is becoming more of an issue

[Gaiadan]

Bump

env STM32F103RC_btt_maple

"request for member 'write' in '((MultiSerial<ForwardSerial<USBSerial>, int, 0>*)this)->MultiSerial<ForwardSerial<USBSerial>, int, 0>::serial1', which is of non-class type 'int'",
	"startLineNumber": 225,
	"startColumn": 68,
	"endLineNumber": 225,
	"endColumn": 68
}

if i disable serial port 2 it works but i want the second serial for my raspberry pi

[thinkyhead]

Let me try to follow the bouncing ball and try to make sense of this.

This concept comes from #21336 by @X-Ryl669 and the value of SERIAL_CATCHALL gets assigned to _SERIAL_LEAF_2 which would otherwise be msSerial2 or MYSERIAL2. The value of _SERIAL_LEAF_2 is used in one of two ways:

// Hook Meatpack if it's enabled on the second leaf
#if ENABLED(MEATPACK_ON_SERIAL_PORT_2)
  typedef MeatpackSerial<decltype(_SERIAL_LEAF_2)> SerialLeafT2;
  extern SerialLeafT2 mpSerial2;
  #define SERIAL_LEAF_2 mpSerial2
#else
  #define SERIAL_LEAF_2 _SERIAL_LEAF_2
#endif

Later, SERIAL_LEAF_2 is used to define the MultiSerial instance.

Should SERIAL_CATCHALL actually be an integer, because it doesn't fit the pattern of other things, or should it be something like MYSERIAL0 or msSerial0 ?

Or, is there some other condition, and the SERIAL_CATCHALL value should be based on the value of SERIAL_PORT or SERIAL_PORT_2, or … ?

It's a lot to review and try to make sense of, but the fix is probably something simple.

[X-Ryl669]

What is the expected port to use in those printer ?
If I understand the intend correctly from #17719, SERIAL_CATCHALL should be a serial port that's overwriting all serial configuration when defined.

I think it can be removed and the proper serial port declared and used instead.
So maybe you can just remove the define line from the Conditional file, and define the other serial port you want to use instead, like you did with #define SERIAL_PORT_2 2

@thinkyhead Can you explain what it was used for initially ?

[GhostlyCrowd]

Bumping this, as is still an issue.