[incomplete implementation] chamber fan, constant fan used

[GMagician]

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

I'm looking to activate some sort of fan to lower temp in chamber and I found this in code:

Marlin/Marlin/src/module/temperature.cpp

Line 1411 in c35e271

set_fan_speed(2, fan_chamber_pwm); // TODO: instead of fan 2, set to chamber fan

I'm wondering if, in this case, it's better to recycle CHAMBER_FAN_INDEX or define this fan by changing //#define CHAMBER_FAN // Enable a fan on the chamber in configuration to specify fan number.

I'll take care of post a PR but a hint is welcome

Bug Timeline

No response

Expected behavior

As code says...a configurable fan

Actual behavior

fan 2 is always used

Steps to Reproduce

No response

Version of Marlin Firmware

bugfix-2.0.x

Printer model

Bear 2.1

Electronics

AGCM4

Add-ons

Chamber sensor and fan

Your Slicer

Cura

Host Software

Repetier Host

[thisiskeithb]

Did you take care of everything in your PR? #21594

[GMagician]

No, since I'm not sure if CHAMBER_FAN_INDEX may be recycled or if it's better to recycle CHAMBER_FAN.
Both are related to chamber fan but what former purpose?

[GMagician]

It seems that there is some duplicated code involving CHAMBER_FAN_INDEX. This fans seems a sort of CHAMBER_FAN_MODE=0 but latter has no AUTO_POWER_CONTROL support.

[github-actions]

This issue has had no activity in the last 60 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 10 days.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.