[BUG] ( LCD SD-card 'Insert' Not Detected For MKS_SGEN_L Board )

[borland1]

Bug Description

When inserting SD-card in SD-card slot of LCD display module, SD-card is not detected, so display's menu does not update with file list/directory.

Steps to Reproduce

With Controller Board MKS_SGEN_L selected,
when enabling LCD's SD-card in Configuration_adv.h file,
line 1153...
#if HAS_SDCARD_CONNECTION
with..
#define SDCARD_CONNECTION LCD

Above configuration properly disables the ONBOARD SD-card and enables the LCD SD-card because both slots use same SD-DETECT_PIN ( P0.27 ).

Suggested Fix.
In file: pins_MKS_SGEN_L.h, line 269...
#if SD_CONNECTION_IS(LCD),
add...
#define SD_DETECT_PIN P0_27

Additional Information

Pin mapping of SD_DETECT_PIN is only defined for SD_CONNECTION_IS( ONBOARD ).

ConfigurationFiles.zip

[thisiskeithb]

That's odd that you have to define it again, because SD_DETECT_PIN should be set to P0_27 on line 211 as long as you're not using a CR10_STOCKDISPLAY (which you aren't):

Marlin/Marlin/src/pins/lpc1768/pins_MKS_SGEN_L.h

Lines 192 to 225 in 6a514a1

	#if HAS_SPI_LCD
	#define BEEPER_PIN P1_31
	#define BTN_ENC P1_30
	#if ENABLED(CR10_STOCKDISPLAY)
	#define LCD_PINS_RS P1_00
	#define BTN_EN1 P0_18
	#define BTN_EN2 P0_15
	#define LCD_PINS_ENABLE P1_22
	#define LCD_PINS_D4 P0_17
	#else
	#define BTN_EN1 P3_25
	#define BTN_EN2 P3_26
	#define LCD_SDSS P0_28
	#define SD_DETECT_PIN P0_27
	#if ENABLED(MKS_12864OLED_SSD1306)
	#define LCD_PINS_DC P0_17
	#define DOGLCD_CS P0_16
	#define DOGLCD_A0 LCD_PINS_DC
	#define DOGLCD_SCK P0_15
	#define DOGLCD_MOSI P0_18
	#define LCD_PINS_RS P1_00
	#define LCD_PINS_D7 P1_22
	#define KILL_PIN -1 // NC
	#else // !MKS_12864OLED_SSD1306

[thisiskeithb]

I moved the SD_DETECT_PIN define under the SD_CONNECTION_IS(LCD) section in PR #16224.

[cjsoong]

The issue was not resolved after the update.

[thisiskeithb]

The issue was not resolved after the update.

Does this pins file work? This is what I submitted originally.

[borland1]

That is equivalent to what was pushed to bugfix-2.0.x.
This is what I found there now.... compiles with 'SUCCESS', looks correct, but less readable for case SD_CONNECTION_IS (LCD) ....

#ifndef SDCARD_CONNECTION
#define SDCARD_CONNECTION ONBOARD
#endif

#define ONBOARD_SD_CS_PIN P0_06 // Chip select for "System" SD card

#if SD_CONNECTION_IS(LCD) || SD_CONNECTION_IS(ONBOARD)
#define SD_DETECT_PIN P0_27
#define SCK_PIN P0_07
#define MISO_PIN P0_08
#define MOSI_PIN P0_09
#if SD_CONNECTION_IS(ONBOARD)
#define SS_PIN ONBOARD_SD_CS_PIN
#else
#define SS_PIN P0_28
#endif
#elif SD_CONNECTION_IS(CUSTOM_CABLE)
#error "No custom SD drive cable defined for this board."
#endif

Maybe cjsoong has board other than MKS_SGEN_L, or can upload his configuration.h, configuration_adv.h, and platformIO.ini files.

[thisiskeithb]

Do the merged changes work for you @borland1?

[borland1]

Keith, I'm not sure what you mean by 'merged changes'. The pull request you sent to bugfix-2.0.x compiles with 'Success'. I have not verified those changes with a SD-card with firmware.bin file on it for my MKS_SGEN_L board. I did verify the display SD-card slot as working with my own edited version, but that was before opening this 'new issue'. Do you want me 'Close' this issue or verify again with firmware.bin file on the board with display attached? cjsoong reported the problem still exist?

[thisiskeithb]

Keith, I'm not sure what you mean by 'merged changes'.

I am referring to the the changes I submitted in the now merged PR #16224.

Please pull the latest bugfix-2.0.x, configure it for your printer, flash the updated firmware, & report back if your issue (LCD-based SD card not working correctly on SGEN-L) is resolved.

[thisiskeithb]

@cjsoong: I didn't realize you weren't the author of this bug report, so unless you have the exact same LCD and motherboard/problem as @borland1, please open a new issue.

[borland1]

Keith,
I just confirmed the LCD SD-card slot is working with the changes you submitted.

Confirmed the following: Display properly shows 'Media Inserted' and 'Media Removed' with card inserted and removed, while menu states 'Print from Media', When inserting or removing card from Onboard SD slot, display properly shows 'Media Inserted' and 'Media Removed' and display menu always states: 'No media'.

Please close this issue report. Thanks for your effort.

[thisiskeithb]

Please close this issue report. Thanks for your effort.

I don't have that power, but you do 🙂

[leytanelectronics2]

is there a solution for the ramps 1.4 board? that's the one I'm using for my setup and I am having the same issue, when I plug the sd in it shows that it has been inserted, but when I go to print from it I get "no media" text. if anyone knows how to fix this for the ramps please let me know.