Fix markbind serve not opening browser
#496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
What is the rationale for this request?
markbind serveshould always open the browser unlessno-openis specified. Right now, it does not open when serving normally (e.g.markbind serve docsdoes not open the browser, even though it should).What changes did you make? (Give an overview)
Fix a programming error that originated from #475.
Provide some example code that this change will affect:
NIL
Is there anything you'd like reviewers to focus on?
NIL
Testing instructions:
markbind serve docsandmarkbind serve docs --one-page userGuide/components.mdshould open the browser.markbind serve docs --no-openandmarkbind serve docs --one-page userGuide/components.md --no-openshould not open the browser.