Fix MapsterMapper#370 where capitalized abbreviations are not mapped … #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properly between records
This was referenced May 29, 2023
|
Hello! Any idea on when this will be published? Even as a prerelease nuget? |
Contributor
|
Hi @RobKoda, I released 7.4.0 yesterday. Apologies for the delay, it's been a busy summer :) |
|
this still happen with property Name FrName |
|
Error still continue and not mapped _ properties i.e. Address_FirstName in 7.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…properly between records
This PR fixes an issue where when you have a destination member that isn't in pascal case for a record, then it will ignore the mapping. (#370)
In
ValueAccessingStrategy.cs, the custom resolver destination member is compared for equality against the ParameterModel destination member. However, in ParameterModel, it modifies the destination member to force it to be Pascal Case. I couldn't figure out exactly why we do this, but it breaks a number of tests if you change it.The only solution I could find that avoids breaking any tests is to compare the two destination members ignoring case. Even if this isn't the correct solution, hopefully this will help someone more familiar create a better solution.